[rust-compiler] Document test-babel-ast.sh status in TODO#36521
Closed
poteto wants to merge 1 commit into
Closed
Conversation
This stack closed out the three `react_compiler_ast` integration tests in `compiler/scripts/test-babel-ast.sh`. Add a brief status section to the e2e parity TODO so future readers know: 1. Where the round-trip / scope tests live and that they're green. 2. Exactly one fixture (`lone-surrogate-string-values.js`) is excluded from the two round-trip tests, deferred to the SWC Group C WTF-8 work that already covers the same root cause. E2e numbers (Babel 1788/1795, SWC 1780/1795, OXC 1704/1795) re-measured at this branch and unchanged from the snapshot at the top of TODO.md, so the existing status table stays as-is. Test plan: - Documentation-only change; cargo build untouched. - `bash compiler/scripts/test-babel-ast.sh`: green (1779/1779 + 1780/1780 + 1779/1779, exit 0).
github-actions
Bot
added
the
React Core Team
Collaborator
Author
|
Withdrawing along with #36519. Test-skipping isn't the right direction; the lone-surrogate fixture will remain a known failure until WTF-8 work lands (already tracked in compiler/crates/TODO.md SWC Group C). Reopening this doc update isn't useful in isolation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stack closed out the three
react_compiler_astintegrationtests in
compiler/scripts/test-babel-ast.sh. Add a brief statussection to the e2e parity TODO so future readers know:
lone-surrogate-string-values.js) isexcluded from the two round-trip tests, deferred to the SWC
Group C WTF-8 work that already covers the same root cause.
E2e numbers (Babel 1788/1795, SWC 1780/1795, OXC 1704/1795)
re-measured at this branch and unchanged from the snapshot at the
top of TODO.md, so the existing status table stays as-is.
Test plan:
bash compiler/scripts/test-babel-ast.sh: green (1779/1779 +1780/1780 + 1779/1779, exit 0).