chore: Remove hatch scripts and replace with built-in hatch utilities#84
Open
jason-famedly wants to merge 3 commits intomainfrom
Open
chore: Remove hatch scripts and replace with built-in hatch utilities#84jason-famedly wants to merge 3 commits intomainfrom
jason-famedly wants to merge 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 83.08% 73.28% -9.81%
==========================================
Files 18 5 -13
Lines 1874 756 -1118
Branches 193 145 -48
==========================================
- Hits 1557 554 -1003
+ Misses 234 143 -91
+ Partials 83 59 -24
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jason-famedly
commented
Apr 8, 2026
| ] | ||
| dependencies = [ | ||
| "jwcrypto", | ||
| "jwcrypto<=1.5.6", |
Member
Author
The 1.5.7 release increased hardening on the JWT token, which requires a stricter length on the token. This needs to be worked around in the testing suite. It is unknown if this will affect production.
62dce8e to
5ef8087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
hatch run cov,hatch formatandhatch lintwith properhatch fmtandhatch test ...options. Based on work done for the synapse-invite-checkerFor the moment, using
hatch fmtto run static analysis will run head first into a wall of issues. To run the formatting only, just runhatch fmt -f🔴 NOTE: One of the consequences of this was changing the coverage data being collected. Previously, this included the testing infrastructure and it's utilities. This has now been removed from the calculation, which was a net-decrease in coverage percent
🔴 NOTE: This pins
jwcryptoto<=1.5.6. See below for reasoning