adding C interface without dep to C++ standard lib#370
Open
Conversation
jwakely
reviewed
Feb 24, 2026
| @@ -0,0 +1,31 @@ | |||
| #ifndef __FAST_FLOAT_STRTOD_H__ | |||
Contributor
There was a problem hiding this comment.
Include guards with double underscores are bad habits, this is a reserved name so has undefined behaviour! FAST_FLOAT_STRTOD_H would make a fine include guard :)
Member
Author
There was a problem hiding this comment.
Thanks. I will fix this. Note that this is experimental and I will not be merging this PR immediately before it has received considerable review from others.
Contributor
There was a problem hiding this comment.
To give some more constructive feedback, this does seem like a useful addition.
Member
Author
There was a problem hiding this comment.
Thanks!!! Much appreciated. You have increased the probability that we will move forward ! ah ah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast_float library does not depend on the standard C++ library at runtime, there is no need to link against the C++ standard library.