fix: use strech and modern env set#10
Conversation
janpio
left a comment
There was a problem hiding this comment.
Looks good, but we'll probably need @joshdholtz to publish the updated version.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Docker build issues by updating the base Debian distribution from jessie to stretch and modernizing ENV syntax. The changes address GPG signature verification errors that were preventing successful builds and eliminate Docker legacy format warnings.
- Updates Debian repository from jessie-backports to stretch-backports
- Converts legacy ENV syntax from "ENV key value" to modern "ENV key=value" format
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Yeah I guess GitHub Action registry would be cool, but downside is you need auth even for a public image for that registry so native pipelines on GitHub Actions would be easy, but 3rd party systems that use that old Docker image would have some troubles switching. Benefit of DockerHub is of course no auth, but seems like no automation is wired up to push there. I'll work to remove Docker from GitHub Actions for a pure Node Action, but fixed their pipeline in meantime - fastlane/github-actions#117 More heavily I then removed docker CI dependency on fastlane itself for pure GitHub Actions here - fastlane/fastlane#29724 |
The Problem
🔑 Building the image that some CI pipelines do - crash due to the aging infrastructure of a Python 2.7 image on an aging debian distro. I'm on a journey to wake up fastlane - first docs, then actions, wip fastlane and now docker.
Less important, a bunch of warnings for modern docker.
The Fix
We use the Debian Stretch, which isn't even the best option, but we have to work against the constraint of Ruby 2.7 base image. The true fix is dropping Ruby 2.x behind, but this will do to get us green in meantime.
closes: #9
Works fine now.