use stl-style and ranged-for iteration for variant containers#48322
Merged
use stl-style and ranged-for iteration for variant containers#48322
Conversation
serra-fastly
approved these changes
Apr 10, 2026
clintjedwards
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48320 mentions that iterating variant containers still involves working with types like
QHashIterator. Qt'sforeachmacro is also used when looping over variant lists. This PR changes all variant iterator usage to STL-style (begin()/end()), and replaces all variant-relatedforeachloops with standard rangedforloops (i.e.for(element : collection)).After this, all variant usage will be free of direct references to Qt, except for when working with APIs that specifically require
QVariant, such asQSettingsandQJson. And of course, custom variant types still requireQ_DECLARE_METATYPE.