clipboard: allow searching the clipboard history#1504
Open
pslldq wants to merge 5 commits intofcitx:masterfrom
Open
clipboard: allow searching the clipboard history#1504pslldq wants to merge 5 commits intofcitx:masterfrom
pslldq wants to merge 5 commits intofcitx:masterfrom
Conversation
added 5 commits
February 3, 2026 23:33
Add an erase method to erase an iterator from the given set. This allow erasing elements while iterating over the set.
Optimize deleting password entries by utilizing the new OrderedSet erase method. This allows to only iterate once over all passwords and directly remove the expired ones. As the erase method returns the iterator for the next element, we avoid incrementing the iterator in the for loop header.
Don't limit the max number of entries. While having a huge number of entries might cause performance/resource issues, allow the user to tune it to their hardware and his needs.
In preparation of enabling the user to search the history, drop the backspace function of deleting the history. History can still be deleted with the delete key.
Implement a search functionality to allow searching for previous clipboard entries. This enables the user to search for a given entry. It works similar to the unicode module, which allows searching for a given unicode symbol.
wengxt
requested changes
Feb 5, 2026
Contributor
Author
|
Hmm, this PR seems to be bugged a bit (for me?) as it still shows the old diff despite the branch being updated: master...pslldq:fcitx5:betterclip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a search functionality for the clipboard to allow searching in the clipboard history. Also don't impose a max history limit (of 30).
I've did some basic test and while the search is not optimized in any way, it works fine on ~21K entries without even maxing out a CPU core.