Skip to content

Update build-collection.yml#28

Merged
avahoffman merged 7 commits intomainfrom
kweav-patch-1
Apr 23, 2025
Merged

Update build-collection.yml#28
avahoffman merged 7 commits intomainfrom
kweav-patch-1

Conversation

@kweav
Copy link
Copy Markdown
Contributor

@kweav kweav commented Mar 19, 2025

Originally I just had to bump the version of upload artifact to v4 in build-collection.yml. Also updated the git config in build-collection.yml. At this point the pull request checks wouldn't startup, but I ran the render course action to verify that the changes to build collection worked (which they did).

pull_request.yml also needed some updates to get the checks to run.

And finally updated a URL in the index file that the URL checker caught.

Found that these updates were needed after using this repo's workflow as an example for another repo and got an error with my workflow saying it needed v4 for upload_artifact. So checked the actions here and saw it was also failing here.

Bump upload artifact to v4
@kweav kweav requested a review from avahoffman March 19, 2025 21:13
@kweav
Copy link
Copy Markdown
Contributor Author

kweav commented Mar 19, 2025

Just had to update my git config on the other project too. wondering if that change will be needed here as well

kweav added 5 commits April 15, 2025 12:05
Update git configure based on similar action on another project
Address startup failure
indentation issues maybe?
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2025

No spelling errors! 🎉
Comment updated at 2025-04-15-17:46:57 with changes from b1286c0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2025

No broken url errors! 🎉
Comment updated at 2025-04-15-17:47:01 with changes from b1286c0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2025

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2025-04-15 with changes from the latest commit b1286c0

update youtube url per url checker
Copy link
Copy Markdown
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

@avahoffman avahoffman merged commit 4d660e3 into main Apr 23, 2025
13 checks passed
@avahoffman avahoffman deleted the kweav-patch-1 branch April 23, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants