chore(firestore-bigquery-export): release version 0.2.11-rc.3 with partitioning config fix#2695
Conversation
…rtitioning config fix
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue where the Firestore BigQuery export extension would crash upon startup if partitioning configuration was not explicitly defined. The changes introduce more resilient handling of partitioning settings by defaulting to a 'NONE' granularity when no configuration is provided, preventing unexpected failures and improving the extension's robustness. The extension's version has been updated to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
|
||
| name: firestore-bigquery-export | ||
| version: 0.2.11 | ||
| version: 0.2.11-rc.3 |
There was a problem hiding this comment.
here we don't actually need the rc, just keep it as 0.2.11. kokoro handles the tag
| @@ -1,3 +1,7 @@ | |||
| ## Version 0.2.11-rc.3 | |||
There was a problem hiding this comment.
same here, we dont need to increment in the changelog, can you stick this in 0.2.11
There was a problem hiding this comment.
Code Review
This pull request updates the extension version to 0.2.11-rc.3 and refactors the BigQuery partitioning configuration logic. A new getPartitioningConfig function is introduced to correctly construct the partitioning object for the FirestoreBigQueryEventHistoryTracker, preventing a startup crash when partitioning configuration is omitted by defaulting to NONE granularity. A review comment suggests adding a warning log when partitioning defaults to NONE due to invalid or incomplete configuration, to improve user debuggability.
| }; | ||
| } | ||
|
|
||
| return { granularity: "NONE" }; |
There was a problem hiding this comment.
While defaulting to no partitioning prevents a crash, it might be confusing for users who have tried to configure partitioning but made a mistake. Silently failing to apply partitioning could lead to unexpected behavior and costs.
Consider adding a warning log here to inform the user that their partitioning configuration is invalid and that partitioning is being disabled. This would greatly improve debuggability for users.
logs.warn("Time partitioning configuration is invalid or incomplete, defaulting to no partitioning.");
return { granularity: "NONE" };| @@ -54,9 +54,9 @@ export class PartitioningConfig { | |||
| private strategy: PartitioningStrategy; | |||
| private type: PartitioningType; | |||
|
|
|||
There was a problem hiding this comment.
hmm if we change this, we will have to re-publish the npm package.. let me investigate
No description provided.