Skip to content

chore(firestore-bigquery-export): release version 0.2.11-rc.3 with partitioning config fix#2695

Open
andyma-star wants to merge 3 commits intofirebase:nextfrom
andyma-star:fix/firestore-bigquery-export-0.2.11-rc.3-partitioning-init
Open

chore(firestore-bigquery-export): release version 0.2.11-rc.3 with partitioning config fix#2695
andyma-star wants to merge 3 commits intofirebase:nextfrom
andyma-star:fix/firestore-bigquery-export-0.2.11-rc.3-partitioning-init

Conversation

@andyma-star
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where the Firestore BigQuery export extension would crash upon startup if partitioning configuration was not explicitly defined. The changes introduce more resilient handling of partitioning settings by defaulting to a 'NONE' granularity when no configuration is provided, preventing unexpected failures and improving the extension's robustness. The extension's version has been updated to 0.2.11-rc.3 to reflect these improvements.

Highlights

  • Partitioning Configuration Fix: Addressed a startup crash that occurred when the partitioning configuration was omitted, ensuring a default 'NONE' granularity is applied.
  • Constructor Update: Modified the PartitioningConfig constructor to accept an optional configuration, defaulting to { granularity: "NONE" } if no configuration is provided.
  • Dynamic Partitioning Setup: Introduced a new getPartitioningConfig function in index.ts to dynamically construct the partitioning settings, aligning with the updated FirestoreBigQueryEventHistoryTracker's expected configuration shape.
  • Version Bump: Released version 0.2.11-rc.3 of the firestore-bigquery-export extension.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.


name: firestore-bigquery-export
version: 0.2.11
version: 0.2.11-rc.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we don't actually need the rc, just keep it as 0.2.11. kokoro handles the tag

@@ -1,3 +1,7 @@
## Version 0.2.11-rc.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, we dont need to increment in the changelog, can you stick this in 0.2.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. sure

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the extension version to 0.2.11-rc.3 and refactors the BigQuery partitioning configuration logic. A new getPartitioningConfig function is introduced to correctly construct the partitioning object for the FirestoreBigQueryEventHistoryTracker, preventing a startup crash when partitioning configuration is omitted by defaulting to NONE granularity. A review comment suggests adding a warning log when partitioning defaults to NONE due to invalid or incomplete configuration, to improve user debuggability.

};
}

return { granularity: "NONE" };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While defaulting to no partitioning prevents a crash, it might be confusing for users who have tried to configure partitioning but made a mistake. Silently failing to apply partitioning could lead to unexpected behavior and costs.

Consider adding a warning log here to inform the user that their partitioning configuration is invalid and that partitioning is being disabled. This would greatly improve debuggability for users.

  logs.warn("Time partitioning configuration is invalid or incomplete, defaulting to no partitioning.");
  return { granularity: "NONE" };

@@ -54,9 +54,9 @@ export class PartitioningConfig {
private strategy: PartitioningStrategy;
private type: PartitioningType;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm if we change this, we will have to re-publish the npm package.. let me investigate

@andyma-star andyma-star requested a review from cabljac March 24, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants