-
Notifications
You must be signed in to change notification settings - Fork 221
Roll back changes from failed release #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @inlined, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to revert the project's state following a failed release. It specifically rolls back the "firebase-functions" package version to its previous stable state ("7.0.4") and prepares the changelog for upcoming features, ensuring the codebase is aligned with a known good version while setting the stage for future development. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be a rollback of a failed release, correctly decrementing the version in package.json and package-lock.json. However, it introduces a new CHANGELOG.md file with a feature entry. This is inconsistent with a rollback and could create confusion about the features included in this version. This changelog entry should be removed as part of the rollback.
| # Changelog | ||
|
|
||
| ## Unreleased | ||
|
|
||
| - feat: Add V1-compatible getters for context and message (#1800) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this pull request is a rollback of a failed release, adding a new feature to the changelog is contradictory. If the feature from #1800 is being rolled back, this changelog entry should be removed to accurately reflect the contents of the release and avoid confusion.
brittanycho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the failed release from yesterday for 7.0.4 (that failed because of github security token)?: https://screenshot.googleplex.com/4Bv9vqV2tk5JjLF
Commit: 506cd84
|
Actually, it seems the release succeeded from an npm perspective but we just didn't create a GitHub release. I'll do that now. |
What it says on the tin