Resolve VPC Connector region if REGION_TBD#10469
Closed
Conversation
This dynamically resolves the VPC connector region to be the same as the function if not defined. This also includes a small comment fix for the region field in Endpoint.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic resolution for VPC connector regions by replacing the REGION_TBD placeholder with the actual deployment region during the preparation phase. It includes updates to the Endpoint type documentation, logic in moveEndpointToRegion, and a new test case to verify the behavior. Review feedback recommends using the build.REGION_TBD constant instead of hardcoded string literals in both the implementation and the test code to maintain consistency and prevent typos.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This dynamically resolves the VPC connector region to be the same as the function if not defined. This also includes a small comment fix for the region field in Endpoint.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
shettyvarun268
approved these changes
May 7, 2026
Contributor
shettyvarun268
left a comment
shettyvarun268
left a comment
There was a problem hiding this comment.
LGTM!
Might want to re-run the failing checks and update the changelog for this
Contributor
Author
|
Closing in favor of #10471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dynamically resolves the VPC connector region to be the same as the function if not defined.
This also includes a small comment fix for the region field in Endpoint.
Scenarios Tested
Create function with VPC connector
firebase deploy --only functionson 15.16.0Update function and use local firebase-tools build
firebase deploy --only functionsUpdate was successful.