Only allow directories to be passed to crashlytics sourcemap upload#10472
Open
tonybaroneee wants to merge 1 commit intocrashlytics2from
Open
Only allow directories to be passed to crashlytics sourcemap upload#10472tonybaroneee wants to merge 1 commit intocrashlytics2from
tonybaroneee wants to merge 1 commit intocrashlytics2from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request restricts the crashlytics:sourcemap:upload command to only accept directories, removing support for single file uploads. Corresponding updates were made to the test suite to use directory paths and handle multiple file assertions. Feedback focused on improving test robustness by verifying all parallel API calls and ensuring warning logs are correctly counted during multiple failures.
tonybaroneee
force-pushed
the
sourcemap-upload-dir-only
branch
from
f18f02d to
387e41a
Compare
tonybaroneee
force-pushed
the
sourcemap-upload-dir-only
branch
from
387e41a to
840a3df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.