fix: use -destination instead of -sdk in scripts/build-for-testing.sh

[ncooke3]

The -destination flag let's Xcode decide which SDK to build against. It fixes an issue where Crashlytics tests weren't building because of the linked watchOS app embedded in the iOS target.

Fixes the Crashlytics tests: https://github.com/firebase/firebase-ios-sdk/actions/runs/19710483584/job/56469451688?pr=15545

Other FTL crons should be unaffected

[gemini-code-assist]

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the build-for-testing.sh script by updating how xcodebuild targets iOS platforms and by removing an unnecessary sudo call. These adjustments aim to enhance the script's reliability and security by aligning with best practices for Xcode command-line operations, leading to a more robust and streamlined build process.

Highlights

• Xcode Build Parameter Update: The build-for-testing.sh script now uses the -destination flag instead of -sdk when invoking xcodebuild for iOS builds. This provides a more precise way to specify the target platform.
• Removed Unnecessary Sudo: The sudo command has been removed from the xcode-select -p call, as this command typically does not require elevated privileges to function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the build-for-testing.sh script. It correctly replaces the deprecated -sdk flag with -destination for xcodebuild, and removes an unnecessary sudo from xcode-select -p, which is a good security practice. I've pointed out a potential issue where the destination platform is hardcoded to iOS, which could conflict with the script's logic for handling different OS types. Overall, good changes that improve the build script.