Skip to content

feat(ai) Add Grounding with Google Maps features#955

Open
DellaBitta wants to merge 9 commits intomasterfrom
ddb-grounding-maps
Open

feat(ai) Add Grounding with Google Maps features#955
DellaBitta wants to merge 9 commits intomasterfrom
ddb-grounding-maps

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Mar 18, 2026

Build current fails because the latest version of Firebase lacks Google Maps Grounding support.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Google Maps grounding capabilities to the AI React application. This feature allows the AI model to incorporate geographical context into its responses, enhancing the relevance and accuracy of location-based queries. The changes include UI updates for activating and configuring Google Maps grounding, as well as necessary backend service and dependency updates to support this new functionality.

Highlights

  • Google Maps Grounding Integration: Introduced a new feature to enable grounding AI responses with Google Maps, allowing the model to leverage geographical information for more relevant and accurate location-based queries.
  • Enhanced UI Controls: Added dedicated UI toggles and input fields in the Right Sidebar for activating Google Maps grounding, enabling a widget, and specifying optional latitude/longitude context, alongside updated disabling logic for conflicting tools.
  • Dynamic Input Disabling: Implemented logic to dynamically disable the prompt input and run button when an invalid or incomplete latitude/longitude pair is provided for Google Maps grounding, ensuring valid input before execution.
  • Firebase Dependency Updates: Upgraded the firebase package to version 12.6.0 and several related @firebase packages, ensuring the application uses the latest SDK features, performance improvements, and security fixes.
  • Refactored Source Display: Modified the chat message component to gracefully handle and display different types of grounding sources, including new Google Maps sources, with appropriate titles and URIs in both tooltips and the sources list.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Google Maps grounding functionality to the AI React application, including updating Firebase dependencies, adding UI controls in the RightSidebar for enabling/disabling Google Maps grounding, toggling a Maps widget, and inputting latitude/longitude for location context. The PromptInput component now accepts a disabled prop, which is used in ChatView to disable input when latitude/longitude are inconsistently provided. The ChatMessage component was updated to correctly display Google Maps sources in the chat history. Review feedback highlights the need to remove a console.error and debugging console.log statements, ensure the googleMaps tool update is non-destructive, and refactor the duplicated isLatLngInvalid logic into a shared utility for improved maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant