feat(ai) Add Grounding with Google Maps features#955
feat(ai) Add Grounding with Google Maps features#955DellaBitta wants to merge 9 commits intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Google Maps grounding capabilities to the AI React application. This feature allows the AI model to incorporate geographical context into its responses, enhancing the relevance and accuracy of location-based queries. The changes include UI updates for activating and configuring Google Maps grounding, as well as necessary backend service and dependency updates to support this new functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Google Maps grounding functionality to the AI React application, including updating Firebase dependencies, adding UI controls in the RightSidebar for enabling/disabling Google Maps grounding, toggling a Maps widget, and inputting latitude/longitude for location context. The PromptInput component now accepts a disabled prop, which is used in ChatView to disable input when latitude/longitude are inconsistently provided. The ChatMessage component was updated to correctly display Google Maps sources in the chat history. Review feedback highlights the need to remove a console.error and debugging console.log statements, ensure the googleMaps tool update is non-destructive, and refactor the duplicated isLatLngInvalid logic into a shared utility for improved maintainability.
Build current fails because the latest version of Firebase lacks Google Maps Grounding support.