-
Notifications
You must be signed in to change notification settings - Fork 2.3k
tests: add periodic sanitizer integration test pipeline #5722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaron-ang
wants to merge
1
commit into
firecracker-microvm:main
Choose a base branch
from
aaron-ang:test/sanitizer-integration-pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #!/usr/bin/env python3 | ||
| # Copyright 2026 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Generate Buildkite pipelines dynamically.""" | ||
|
|
||
| from common import BKPipeline | ||
|
|
||
| pipeline = BKPipeline(with_build_step=False) | ||
|
|
||
| pipeline.build_group_per_arch( | ||
| "sanitizers", | ||
| pipeline.devtool_test( | ||
| devtool_opts="--no-build", | ||
| pytest_opts="-m nonci integration_tests/build/test_sanitizers.py", | ||
| ), | ||
| ) | ||
|
|
||
| print(pipeline.to_json()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Copyright 2026 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| """Run Rust integration tests under sanitizers.""" | ||
|
|
||
| import platform | ||
|
|
||
| import pytest | ||
|
|
||
| from framework import defs | ||
| from host_tools.cargo_build import cargo, get_rustflags | ||
|
|
||
| TARGET = f"{platform.machine()}-unknown-linux-gnu" | ||
| SANITIZERS = ("address",) | ||
| REPO_ROOT = defs.FC_WORKSPACE_DIR | ||
| VMM_TEST_TARGETS = sorted((REPO_ROOT / "src" / "vmm" / "tests").glob("*.rs")) | ||
|
|
||
|
|
||
| @pytest.mark.nonci | ||
| @pytest.mark.timeout(3600) | ||
| @pytest.mark.parametrize("sanitizer", SANITIZERS) | ||
| def test_rust_integration_tests_under_sanitizer(sanitizer): | ||
| """Run vmm Rust integration tests under the specified sanitizer.""" | ||
| cargo_args = " ".join( | ||
| [ | ||
| f"--target {TARGET}", | ||
| "-p vmm", | ||
| *(f"--test {path.stem}" for path in VMM_TEST_TARGETS), | ||
| ] | ||
| ) | ||
| target_dir = defs.LOCAL_BUILD_PATH / "cargo_target" / "sanitizers" / sanitizer | ||
| rustflags = get_rustflags() + f"-Zsanitizer={sanitizer}" | ||
| cargo( | ||
| "test", | ||
| cargo_args, | ||
| "--test-threads=1", | ||
| nightly=True, | ||
| cwd=str(REPO_ROOT), | ||
| env={ | ||
| "CARGO_TARGET_DIR": str(target_dir), | ||
| "RUSTFLAGS": rustflags, | ||
| }, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.