Skip to content

block: add read-only VMDK disk image support#5741

Open
ChengyuZhu6 wants to merge 1 commit intofirecracker-microvm:mainfrom
ChengyuZhu6:vmdk
Open

block: add read-only VMDK disk image support#5741
ChengyuZhu6 wants to merge 1 commit intofirecracker-microvm:mainfrom
ChengyuZhu6:vmdk

Conversation

@ChengyuZhu6
Copy link
Copy Markdown

Introduce read-only VMDK (monolithicFlat) support using the imago library.

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Introduce read-only VMDK (monolithicFlat) support using the imago
library.

Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
@hsiangkao
Copy link
Copy Markdown

@ChengyuZhu6 what prevents this as a draft?

@ShadowCurse
Copy link
Copy Markdown
Contributor

Hi @ChengyuZhu6, unfortunately we don't have enough bandwidth to review this for now.

@hsiangkao
Copy link
Copy Markdown

Hi @ChengyuZhu6, unfortunately we don't have enough bandwidth to review this for now.

@ShadowCurse I guess this one is not complicated and it seems almost half the change is test cases.
Since it uses imago library to handle vmdk format, I guess the remaining logic should be straight-forward?

Also I guess the commit message should be improved to make the usage clear at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants