feat(artifacts): create an AL2023 CI rootfs#5772
Draft
JamesC1305 wants to merge 4 commits intofirecracker-microvm:mainfrom
Draft
feat(artifacts): create an AL2023 CI rootfs#5772JamesC1305 wants to merge 4 commits intofirecracker-microvm:mainfrom
JamesC1305 wants to merge 4 commits intofirecracker-microvm:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5772 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 276 276
Lines 29340 29340
=======================================
Hits 24359 24359
Misses 4981 4981
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
TODO: we agreed that our medium-term solution will be to run AL2023 with 6.1 kernels and maintain ubuntu for 5.10. Once 5.10 gets deprecated (#5701), we will switch to use AL2023 only.I need to modify this PR accordingly. |
JamesC1305
force-pushed
the
create-al2023-rootfs
branch
from
47c5999 to
3290135
Compare
Contributor
Author
|
Updated code to run 5.10 on ubuntu. The default otherwise should be 6.1. Running this in a pipeline daily now with the new artifacts. |
Create a new subdirectory `rootfs` under `resources` and move `overlay` and ubuntu CI rootfs setup script underneath. This should help prevent the `resources` base directory from becoming too cluttered. Also rename previous `chroot.sh` to `setup-ubuntu-ci.sh`, to more accurately reflect its purpose (which is to be executed inside the ubuntu image and perform the setup needed). These should help make the structure cleaner when a new setup script is added for an AL2023 rootfs. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Define the build instructions for an Amazon Linux 2023 rootfs to be used in CI. A new 'customisation' script is defined with all commands to be run inside the image. The goal is ensure all our tests pass correctly with the new rootfs. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Add a new member of the Microvm class, GuestDisrto, which contains distro-specific information. The currently included fields are hostname (set in rootfs build), ssh_service (Ubuntu uses ssh.service vs AL2023's sshd.service), os_release_token (displayed as part of /etc/os-release), and shell_prompt. These fields are used a few different tests. The GuestDistro class makes it easier to extend if new fields are required. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Now that we have an additional CI rootfs (amazon linux), our fixtures must be modified accordingly. For now, the default is Amazon linux, and new a new rootfs_any fixture has been created to be used by uvm_plain_any. TBD: running tests on both rootfs (via `uvm_plain_any`) adds 582 additional test cases. Do we really need this? Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
JamesC1305
force-pushed
the
create-al2023-rootfs
branch
from
d272bae to
b5c2467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a new build process for an Amazon Linux 2023 CI rootfs and integrate it into our test framework.
To discuss: how do we want to handle running tests on Ubuntu vs. AL2023? If we run tests on both our test count doubles (~1000 -> ~2000 cases). Right now, I've created a new fixture
rootfs_any(uses both) that is used only inuvm_plain_any. Any tests relying onrootfsorrootfs_rwremain on Ubuntu for now.TODO: update
tests/README.mdto contain info about AL2023 rootfs.Changes
resourcestoresources/rootfssetup-al2023-ci.shthat performs all required setup for new rootfsGuestDistroclass containing distro-specific paths (to fix tests relying on hardcoded ubuntu values)Reason
We will need an AL2023 rootfs for future testing purposes.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.