Skip to content

Add PCI hotplug support #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilstam wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add PCI hotplug support #5786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a22ee0f
api_server_adapter: Move handle_request() out of process()
ilstam Feb 17, 2026
d1eed51
api_server_adapter: Pass EventManager to handle_request()
ilstam Feb 25, 2026
15ebb4b
devices: pmem: Remove unwrap() from alloc_region()
ilstam Mar 4, 2026
baca68a
vmm: Rename {Entropy,Pmem}Device errors to {Entropy,Pmem}Config
ilstam Mar 5, 2026
1a9f3ca
vmm: Add hotplug support for Block,Pmem,Net
ilstam Feb 27, 2026
1baa78c
seccomp: Allow syscalls needed for device hotplug
ilstam Mar 20, 2026
3577aa4
pci_mngr: Add hotplug tests
ilstam Mar 20, 2026
ab2c7a6
tests: functional: Add hotplugging tests
ilstam Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 141 additions & 0 deletions resources/seccomp/aarch64-unknown-linux-musl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,75 @@
}
]
},
{
"syscall": "mmap",
Comment thread
ilstam marked this conversation as resolved.
"comment": "Used by pmem device to mmap the backing file",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 16385,
"comment": "libc::MAP_SHARED | libc::MAP_NORESERVE"
}
]
},
{
"syscall": "mmap",
"comment": "Used by pmem device for aligned anonymous mapping",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 16418,
"comment": "libc::MAP_PRIVATE | libc::MAP_NORESERVE | libc::MAP_ANONYMOUS"
}
]
},
{
"syscall": "mmap",
"comment": "Used by pmem device to overlay file mapping on anonymous region",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 16401,
"comment": "libc::MAP_SHARED | libc::MAP_NORESERVE | libc::MAP_FIXED"
}
]
},
{
"syscall": "mmap",
"comment": "Used by IovDeque ring buffer for net device hotplug",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 17,
"comment": "libc::MAP_SHARED | libc::MAP_FIXED"
}
]
},
{
"syscall": "memfd_create",
Comment thread
ilstam marked this conversation as resolved.
"comment": "Used by IovDeque ring buffer for net device hotplug"
},
{
"syscall": "fcntl",
"comment": "Used by IovDeque to seal memfd during net device hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1033,
"comment": "F_ADD_SEALS"
}
]
},
{
"syscall": "rt_sigaction",
"comment": "rt_sigaction is used by libc::abort during a panic to install the default handler for SIGABRT",
Expand Down Expand Up @@ -353,6 +422,26 @@
}
]
},
{
"syscall": "timerfd_create",
"comment": "Needed for creating rate limiters during device hotplug",
"args": [
{
"index": 0,
"type": "dword",
"op": "eq",
"val": 1,
"comment": "CLOCK_MONOTONIC"
},
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 526336,
"comment": "TFD_NONBLOCK | TFD_CLOEXEC"
}
]
},
{
"syscall": "timerfd_settime",
"comment": "Needed for rate limiting and metrics",
Expand Down Expand Up @@ -465,6 +554,58 @@
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for registering ioeventfds during device hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1077980793,
"comment": "KVM_IOEVENTFD"
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for opening tap device during net hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1074025674,
"comment": "TUNSETIFF"
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for configuring tap offload during net hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1074025680,
"comment": "TUNSETOFFLOAD"
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for setting tap vnet header size during net hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1074025688,
"comment": "TUNSETVNETHDRSZ"
}
]
},
{
"syscall": "sched_yield",
"comment": "Used by the rust standard library in std::sync::mpmc. Firecracker uses mpsc channels from this module for inter-thread communication"
Expand Down
141 changes: 141 additions & 0 deletions resources/seccomp/x86_64-unknown-linux-musl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,75 @@
}
]
},
{
"syscall": "mmap",
"comment": "Used by pmem device to mmap the backing file",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 16385,
"comment": "libc::MAP_SHARED | libc::MAP_NORESERVE"
}
]
},
{
"syscall": "mmap",
"comment": "Used by pmem device for aligned anonymous mapping",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 16418,
"comment": "libc::MAP_PRIVATE | libc::MAP_NORESERVE | libc::MAP_ANONYMOUS"
}
]
},
{
"syscall": "mmap",
"comment": "Used by pmem device to overlay file mapping on anonymous region",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 16401,
"comment": "libc::MAP_SHARED | libc::MAP_NORESERVE | libc::MAP_FIXED"
}
]
},
{
"syscall": "mmap",
"comment": "Used by IovDeque ring buffer for net device hotplug",
"args": [
{
"index": 3,
"type": "dword",
"op": "eq",
"val": 17,
"comment": "libc::MAP_SHARED | libc::MAP_FIXED"
}
]
},
{
"syscall": "memfd_create",
"comment": "Used by IovDeque ring buffer for net device hotplug"
},
{
"syscall": "fcntl",
"comment": "Used by IovDeque to seal memfd during net device hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1033,
"comment": "F_ADD_SEALS"
}
]
},
{
"syscall": "rt_sigaction",
"comment": "rt_sigaction is used by libc::abort during a panic to install the default handler for SIGABRT",
Expand Down Expand Up @@ -353,6 +422,26 @@
}
]
},
{
"syscall": "timerfd_create",
"comment": "Needed for creating rate limiters during device hotplug",
"args": [
{
"index": 0,
"type": "dword",
"op": "eq",
"val": 1,
"comment": "CLOCK_MONOTONIC"
},
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 526336,
"comment": "TFD_NONBLOCK | TFD_CLOEXEC"
}
]
},
{
"syscall": "timerfd_settime",
"comment": "Needed for rate limiting and metrics",
Expand Down Expand Up @@ -477,6 +566,58 @@
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for registering ioeventfds during device hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1077980793,
"comment": "KVM_IOEVENTFD"
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for opening tap device during net hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1074025674,
"comment": "TUNSETIFF"
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for configuring tap offload during net hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1074025680,
"comment": "TUNSETOFFLOAD"
}
]
},
{
"syscall": "ioctl",
"comment": "Needed for setting tap vnet header size during net hotplug",
"args": [
{
"index": 1,
"type": "dword",
"op": "eq",
"val": 1074025688,
"comment": "TUNSETVNETHDRSZ"
}
]
},
{
"syscall": "sched_yield",
"comment": "Used by the rust standard library in std::sync::mpmc. Firecracker uses mpsc channels from this module for inter-thread communication"
Expand Down
Loading
Loading