[BHP1-1546] Add Optimized Contain Diagram#236
Open
Kcheung42 wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
SIGContainAdapter::doContainRunWithOptimalResourceto now also process a range of simulations after the optimal production rate has been computed and ensure getters for the points are now exposed in wasmRelated Issues
Closes BHP1-1546
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)Testing
Open local vms and run migration script
migrations.2026-05-11-add-optimized-contain-diagramIn VMS, Navigate to Contain Module page
Verify there is now a new accordion for Diagrams
Verify there are now 2 contain diagrams, select edit to view the form of attributes a user can update
Open local App and sync vms
Open this worksheet:
BHP1-1546.zip
Re-run this worksheet
Navigate to results page and verify there is a new diagram for the Production Rate vs Containment area diagram
Screenshot