[IN PROGRESS] data pipe#3
Open
ruiting-chen wants to merge 6 commits into
Open
Conversation
…o RingProducer used to check if ready to clean up a connection in data pipe
…and AsyncStream implementations
ruiting-chen
force-pushed
the
feat/data-pipe
branch
from
f23340f to
2c901d6
Compare
GregoryLi360
reviewed
May 7, 2026
| Err(StreamError::ConnectionReset) | ||
| } | ||
| Some(FrameType::Data) => { | ||
| read_exact(&mut self.pipe, &mut buf[..payload_len as usize]); |
Contributor
There was a problem hiding this comment.
payload_len could overflow if header is malformed
Author
There was a problem hiding this comment.
updated: recv now reads min(payload_len, buf.len()) bytes, the number of remaining bytes in the payload is tracked in current_frame_remaining and read on subsequent calls to recv
GregoryLi360
reviewed
May 7, 2026
| } | ||
| Some(FrameType::Data) => { | ||
| let len = payload_len as usize; | ||
| read_exact(&mut self.pipe, &mut buf[..len]).await; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches off feat/bidirectional-pipe