Skip to content

[chore] add typed error for executor #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fkuloff wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

[chore] add typed error for executor #867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dc49f0
[shell-operator] add StderrError type for typed stderr error handling
Fkuloff Apr 13, 2026
99433e9
[shell-operator] add StderrError type for typed stderr error handling
Fkuloff Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/executor/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ func Run(cmd *exec.Cmd) error {
return cmd.Run()
}

// StderrError is returned by RunAndLogLines when a command fails and produces
// output on stderr. Callers can use errors.As to access the raw stderr content.
type StderrError struct {
Message string
}

func (e *StderrError) Error() string {
return e.Message
}

type Executor struct {
cmd *exec.Cmd
logProxyHookJSON bool
Expand Down Expand Up @@ -147,7 +157,7 @@ func (e *Executor) RunAndLogLines(ctx context.Context, logLabels map[string]stri
err := e.cmd.Run()
if err != nil {
if len(stdErr.Bytes()) > 0 {
return nil, fmt.Errorf("stderr: %s", stdErr.String())
return nil, &StderrError{Message: stdErr.String()}
}

return nil, fmt.Errorf("cmd run: %w", err)
Expand Down
Loading