feat: reject EIP-7825 over-limit transactions early#192
Draft
yizhang0901 wants to merge 1 commit intomainfrom
Draft
feat: reject EIP-7825 over-limit transactions early#192yizhang0901 wants to merge 1 commit intomainfrom
yizhang0901 wants to merge 1 commit intomainfrom
Conversation
Reject any tx submitted to Protect RPC with gasLimit > 2^24 (16,777,216) at the RPC layer, before forwarding to the relay. Returns a JSON-RPC -32602 error referencing EIP-7825 so the caller knows to lower the gas limit. Behavior unchanged for txs within cap. The cap value is defined locally rather than imported from go-ethereum's params.MaxTxGas because the pinned go-ethereum version (v1.15.2) predates EIP-7825. A comment marks the constant for replacement next time go-ethereum is bumped to >= v1.16.5. Closes #138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject any tx submitted to Protect RPC with gasLimit > 2^24 (16,777,216) at the RPC layer, before forwarding to the relay. Returns a JSON-RPC -32602 error referencing EIP-7825 so the caller knows to lower the gas limit. Behavior unchanged for txs within cap.
The cap value is defined locally rather than imported from go-ethereum's params.MaxTxGas because the pinned go-ethereum version (v1.15.2) predates EIP-7825. A comment marks the constant for replacement next time go-ethereum is bumped to >= v1.16.5.