Update karma config to allow requiring of additional bower components#49
Open
scottillogical wants to merge 1 commit intoflightjs:masterfrom
Open
Update karma config to allow requiring of additional bower components#49scottillogical wants to merge 1 commit intoflightjs:masterfrom
scottillogical wants to merge 1 commit intoflightjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue when attempting to add another bower component and referencing it in my component test - I got an error only in the test "ERROR: 'There is no timestamp for /base/app/bower_components/handlebars/handlebars.js!'" from karma. It's a confusing error, and I think we should by default include bower components in karma so that you can require stuff in your app code and it won't break tests - and the solution to that would be to just have karma load all the bower components anyways, I think.