Fix bugs and simplify FLIMJ development #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UIService approach works on Windows (not sure about macOS) but not Linux. Trying to open files on linux results in a strange hang/lock of FLIMJ.
This commit ports the mouse events that the JavaScript components were handling into the PlotCtrl.java controller module. This allows us to remove our need for JavaScript, greatly simplifying development.
When trying to load the .fxml files into SceneBuilder for editing SceneBuilder attempts to register the validation support (vs) for the NumericalHelper.java file but clashes with an existing vs, preventing the file from loading. This commit ensures only one vs is created and registered and also prevents registering the vs entirely if SceneBuilder is running.
SceneBuilder does not understand the "fx:reference" tag and fails to match it to the defined function. Moving the function definition to the root of the .fxml does not resolve this. Explicitly defining the effect resolves this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some bug fixes and simplifies the process to develop the
flimj-uilayer. Importantly this PR makes it possible to open/edit the.fxmlUI files with SceneBuilder:Here's a list of what this PR does:
.fxmllayout files so they can be opened/edited with SceneBuilder.PlotCtrl.javacontroller.I still need to test this build on the following systems before I feel comfortable merging this.