Skip ETag header on cache_bust to prevent stale webhook syncs#987
Merged
jnunemaker merged 1 commit intomainfrom Mar 25, 2026
Merged
Skip ETag header on cache_bust to prevent stale webhook syncs#987jnunemaker merged 1 commit intomainfrom
jnunemaker merged 1 commit intomainfrom
Conversation
When the webhook middleware triggers a sync with cache_bust: true, the Http adapter was still sending the If-None-Match header with the cached ETag. If the server returned 304 Not Modified, the adapter returned stale cached data and the local adapter never got updated. This caused 5-10 minute delays for toggle changes to propagate in webhook mode. Now when cache_bust is true, the If-None-Match header is omitted so the server always returns a full 200 response with fresh data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache_bust: trueis passed toHttp#get_all(via webhook sync), skip theIf-None-Matchheader so the server can't return a 304 with stale data_cbquery param busted CDN caches but the ETag header still allowed the origin to short-circuit with 304 Not Modified, causing the local adapter to never get updatedTest plan
If-None-Matchheader is not sent whencache_bust: true🤖 Generated with Claude Code