Block settings import in read_only mode#988
Closed
joaoserra91 wants to merge 1 commit intoflippercloud:mainfrom
Closed
Block settings import in read_only mode#988joaoserra91 wants to merge 1 commit intoflippercloud:mainfrom
joaoserra91 wants to merge 1 commit intoflippercloud:mainfrom
Conversation
Add render_read_only guard to Import#post, matching the pattern used by all other write actions. Hide the import and cloud migration forms in the settings view when write is not allowed.
Collaborator
|
Merged over in #989. I thought it pulled your commit as well. Sorry about that. Thanks for suggestion. I didn't merge this directly because I think migrate still makes sense to show. It's still only a read in flipper local, only a write to cloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add render_read_only guard to Import#post, matching the pattern used by all other write actions.
Hide the import and cloud migration forms
in the settings view when write is not allowed.