encode_opentelemetry: add cut off for otel payloads for prometheus mimir#223
encode_opentelemetry: add cut off for otel payloads for prometheus mimir#223
Conversation
In Promethemus mimir, it requests to limit for 5 minutes in the same batch: https://github.com/grafana/mimir/blob/main/pkg/distributor/distributor.go#L1010-L1020 Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
what is the side effect of this for other endpoints/users ? is it ok to remove metrics for everybody ? |
|
A far I investigated fluent-bit is repeating infinitely (until restarted) metrics from devices or mounts that no longer exist: Trying to push metrics from 3 days ago... (tmpfs filesystem after user session) Regards |
Just for confirming that this your log is applied this patch or not? |
Ah sorry, i'ts a standard 3.1.2 version, I can try to compile from this branch and confirm. Regards |
…led otel payloads Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
I added APIs to specify cutoff options. This could be avoiding breaking changes for users who are using otel encoding. |
…ecific one Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
faab663 to
6c74f7e
Compare
…ting Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
6c74f7e to
ed94318
Compare
|
Is this being planned in for a release soon? Any other testing etc. that is needed? |
|
I believe so. But even if it will be merged into fluent-bit tree, there is more works for implementing the cutoff related parameters on out_opentelemetry. |
This issue is reported in fluent/fluent-bit#9400.
This is because Prometheus mimir limits the metrics' timestamps within 5 minutes in the same batch:
https://github.com/grafana/mimir/blob/main/pkg/distributor/distributor.go#L1010-L1020