Skip to content

Backport(v1.19): benchmark: Use IO#size instead of File.size to speed up file generation on Windows (#5277) #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: v1.19
Choose a base branch
from
Open

Backport(v1.19): benchmark: Use IO#size instead of File.size to speed up file generation on Windows (#5277) #5290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/benchmark.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

loop do
f.puts data
break if File.size(BENCHMARK_FILE_PATH) > BENCHMARK_FILE_SIZE
break if f.size > BENCHMARK_FILE_SIZE
end
end
end
Expand Down