Backport(v1.19): buffer: warn if default timekey (1d) will be used (#5276)#5291
Open
github-actions[bot] wants to merge 1 commit intov1.19from
Open
Backport(v1.19): buffer: warn if default timekey (1d) will be used (#5276)#5291github-actions[bot] wants to merge 1 commit intov1.19from
github-actions[bot] wants to merge 1 commit intov1.19from
Conversation
**Which issue(s) this PR fixes**:
Fixes #
**What this PR does / why we need it**:
By default, the value of timekey interval was set as interval 1d.
Without changing flush related parameters, it will not be flushed at all
in that period. This behavior is intentional design, but it might be
surprised in some use cases.
So, in some doubtful use-case, emit warning for it.
```
Before:
no buffer configuration # no warning
<buffer>
@type file # no warning
</buffer>
<buffer time>
@type file # no warning
</buffer>
<buffer []>
@type file # no warning
</buffer>
After:
no buffer configuration # warning
<buffer>
@type file # warning
</buffer>
<buffer time>
@type file # warning
</buffer>
<buffer []>
@type file # no warning
</buffer>
```
**Docs Changes**:
N/A
**Release Note**:
N/A
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5276
Fixes #
What this PR does / why we need it:
By default, the value of timekey interval was set as interval 1d. Without changing flush related parameters, it will not be flushed at all in that period. This behavior is intentional design, but it might be surprised in some use cases.
So, in some doubtful use-case, emit warning for it.
Docs Changes:
N/A
Release Note:
N/A