feat(e2e): add backward compatibility e2e tests#5681
feat(e2e): add backward compatibility e2e tests#5681jakharmonika364 wants to merge 1 commit intofluid-cloudnative:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial end-to-end test to validate the backward compatibility of Fluid during control plane upgrades. By simulating an upgrade from a stable release to the current development version, it ensures that existing datasets remain fully functional and accessible, thereby enhancing the robustness and reliability of the Fluid system. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @jakharmonika364. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
21dc990 to
e1da069
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a new e2e test for backward compatibility, which is a great addition. The changes to deploy-fluid-to-kind.sh to support upgrades are correct. I've reviewed the new test script gha-backward-compatibility.sh and found a couple of areas for improvement in the wait logic functions. Specifically, one function has a bug that can cause premature failure and lacks a timeout, while another can be improved for readability and performance by using modern shell features. Please see my detailed comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5681 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 444 444
Lines 30540 30540
=======================================
Hits 18694 18694
Misses 10306 10306
Partials 1540 1540 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
56d6897 to
36a5d01
Compare
Signed-off-by: Monika Jakhar <jakharmonika364@gmail.com>
36a5d01 to
9aec00d
Compare
|



Ⅰ. Describe what this PR does
Adds an e2e test workflow to verify backward compatibility during upgrades. The new Github Action installs the current stable release via Helm, creates an Alluxio dataset, upgrades the control plane using the locally built images, and verifies that the existing dataset is still accessible via a test job.
Also tweaked .github/scripts/deploy-fluid-to-kind.sh to use
helm upgrade --installinstead of justhelm installso the script can be reused for the upgrade testing.Ⅱ. Does this pull request fix one issue?
fixes #2630
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Added backward-compatibility-e2e.yml and the corresponding script gha-backward-compatibility.sh to run the upgrade flow.
Ⅳ. Describe how to verify it
The "E2E Backward Compatibility Check" CI job should successfully pass in this PR.
Ⅴ. Special notes for reviews
NONE