Skip to content

feat(e2e): add backward compatibility e2e tests#5681

Open
jakharmonika364 wants to merge 1 commit intofluid-cloudnative:masterfrom
jakharmonika364:fix-backward-compatibility-e2e
Open

feat(e2e): add backward compatibility e2e tests#5681
jakharmonika364 wants to merge 1 commit intofluid-cloudnative:masterfrom
jakharmonika364:fix-backward-compatibility-e2e

Conversation

@jakharmonika364
Copy link
Contributor

Ⅰ. Describe what this PR does

Adds an e2e test workflow to verify backward compatibility during upgrades. The new Github Action installs the current stable release via Helm, creates an Alluxio dataset, upgrades the control plane using the locally built images, and verifies that the existing dataset is still accessible via a test job.

Also tweaked .github/scripts/deploy-fluid-to-kind.sh to use helm upgrade --install instead of just helm install so the script can be reused for the upgrade testing.


Ⅱ. Does this pull request fix one issue?

fixes #2630


Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Added backward-compatibility-e2e.yml and the corresponding script gha-backward-compatibility.sh to run the upgrade flow.


Ⅳ. Describe how to verify it

The "E2E Backward Compatibility Check" CI job should successfully pass in this PR.


Ⅴ. Special notes for reviews

NONE

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial end-to-end test to validate the backward compatibility of Fluid during control plane upgrades. By simulating an upgrade from a stable release to the current development version, it ensures that existing datasets remain fully functional and accessible, thereby enhancing the robustness and reliability of the Fluid system.

Highlights

  • New E2E Test Workflow: Implemented a GitHub Actions workflow to test backward compatibility during Fluid control plane upgrades, ensuring existing datasets remain accessible.
  • Script Enhancement: Modified the deploy-fluid-to-kind.sh script to use helm upgrade --install, making it reusable for upgrade testing scenarios.
Changelog
  • .github/scripts/deploy-fluid-to-kind.sh
    • Updated helm install command to helm upgrade --install for upgrade scenarios.
    • Added || true to kubectl create ns fluid-system to prevent script failure if the namespace already exists.
  • .github/scripts/gha-backward-compatibility.sh
    • Added a new shell script to orchestrate the backward compatibility E2E test, including functions for setting up an old Fluid version, creating datasets, upgrading Fluid, and verifying compatibility.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/backward-compatibility-e2e.yml
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 7, 2026

Hi @jakharmonika364. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakharmonika364 jakharmonika364 force-pushed the fix-backward-compatibility-e2e branch from 21dc990 to e1da069 Compare March 7, 2026 14:31
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new e2e test for backward compatibility, which is a great addition. The changes to deploy-fluid-to-kind.sh to support upgrades are correct. I've reviewed the new test script gha-backward-compatibility.sh and found a couple of areas for improvement in the wait logic functions. Specifically, one function has a bug that can cause premature failure and lacks a timeout, while another can be improved for readability and performance by using modern shell features. Please see my detailed comments.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.21%. Comparing base (a69c888) to head (9aec00d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5681   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files         444      444           
  Lines       30540    30540           
=======================================
  Hits        18694    18694           
  Misses      10306    10306           
  Partials     1540     1540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakharmonika364 jakharmonika364 force-pushed the fix-backward-compatibility-e2e branch 3 times, most recently from 56d6897 to 36a5d01 Compare March 8, 2026 05:40
Signed-off-by: Monika Jakhar <jakharmonika364@gmail.com>
@jakharmonika364 jakharmonika364 force-pushed the fix-backward-compatibility-e2e branch from 36a5d01 to 9aec00d Compare March 8, 2026 06:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add e2e testcase to check backward compatibility

1 participant