Skip to content

This PR is to add comments to genDataLoadValue in pkg/ddc/alluxio/load_data.go. #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xuhrrr wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

This PR is to add comments to genDataLoadValue in pkg/ddc/alluxio/load_data.go. #5840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/ddc/alluxio/load_data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ func (e *AlluxioEngine) generateDataLoadValueFile(r cruntime.ReconcileRequestCon
return valueFile.Name(), nil
}

// genDataLoadValue builds a DataLoadValue for the Fluid dataloader Helm chart from the Alluxio worker
// image, the target Dataset, and the DataLoad CR. It fills scheduling options (affinity including
// run-after injection, nodeSelector, tolerations, schedulerName), resolves target paths with
// Fluid-native mount detection, and attaches owner references for the rendered load Job.
Comment on lines +103 to +106
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description of scheduling options is grammatically ambiguous. The current phrasing suggests that nodeSelector, tolerations, and schedulerName are examples of affinity (due to the "including" clause), whereas they are actually distinct fields in the DataLoadValue struct. Clarifying this improves the documentation's accuracy.

Suggested change
// genDataLoadValue builds a DataLoadValue for the Fluid dataloader Helm chart from the Alluxio worker
// image, the target Dataset, and the DataLoad CR. It fills scheduling options (affinity including
// run-after injection, nodeSelector, tolerations, schedulerName), resolves target paths with
// Fluid-native mount detection, and attaches owner references for the rendered load Job.
// genDataLoadValue builds a DataLoadValue for the Fluid dataloader Helm chart from the Alluxio worker
// image, the target Dataset, and the DataLoad CR. It fills scheduling options (affinity, nodeSelector,
// tolerations, schedulerName), handles run-after affinity injection, resolves target paths with
// Fluid-native mount detection, and attaches owner references for the rendered load Job.

func (e *AlluxioEngine) genDataLoadValue(image string, targetDataset *datav1alpha1.Dataset, dataload *datav1alpha1.DataLoad) (*cdataload.DataLoadValue, error) {
// image pull secrets
// if the environment variable is not set, it is still an empty slice
Expand Down
Loading