Skip to content

Migrate compass_app to SharedPreferencesAsync #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshyadavDeveloper wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −8
Open

Migrate compass_app to SharedPreferencesAsync #2841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions background_isolate_channels/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@ class _MyHomePageState extends State<MyHomePage> {
// Write the value to [SharedPreferences] which will get read on the
// [SimpleDatabase]'s isolate. For this example the value is always true
// just for demonstration purposes.
final Future<void> sharedPreferencesSet = SharedPreferences.getInstance()
.then(
(sharedPreferences) => sharedPreferences.setBool('isDebug', true),
);
final SharedPreferencesAsync sharedPreferences = SharedPreferencesAsync();

final Future<void> sharedPreferencesSet = sharedPreferences.setBool(
'isDebug',
true,
);
final Future<Directory> tempDirFuture = path_provider
.getTemporaryDirectory();

Expand Down
2 changes: 1 addition & 1 deletion compass_app/app/integration_test/app_server_data_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ void main() {

setUpAll(() async {
// Clear any stored shared preferences
final sharedPreferences = await SharedPreferences.getInstance();
final sharedPreferences = SharedPreferencesAsync();
await sharedPreferences.clear();

// Start the dart server
Expand Down
12 changes: 9 additions & 3 deletions compass_app/app/lib/data/services/shared_preferences_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ class SharedPreferencesService {

Future<Result<String?>> fetchToken() async {
try {
final sharedPreferences = await SharedPreferences.getInstance();
final sharedPreferences = SharedPreferencesAsync();

_log.finer('Got token from SharedPreferences');
return Result.ok(sharedPreferences.getString(_tokenKey));

return Result.ok(await sharedPreferences.getString(_tokenKey));
} on Exception catch (e) {
_log.warning('Failed to get token', e);
return Result.error(e);
Expand All @@ -24,14 +26,18 @@ class SharedPreferencesService {

Future<Result<void>> saveToken(String? token) async {
try {
final sharedPreferences = await SharedPreferences.getInstance();
final sharedPreferences = SharedPreferencesAsync();

if (token == null) {
_log.finer('Removed token');

await sharedPreferences.remove(_tokenKey);
} else {
_log.finer('Replaced token');

await sharedPreferences.setString(_tokenKey, token);
}

return const Result.ok(null);
} on Exception catch (e) {
_log.warning('Failed to set token', e);
Expand Down