Skip to content

rfc20: drop the attributes section#402

Merged
mergify[bot] merged 1 commit intoflux-framework:masterfrom
garlick:rfc20_attr
Mar 31, 2026
Merged

rfc20: drop the attributes section#402
mergify[bot] merged 1 commit intoflux-framework:masterfrom
garlick:rfc20_attr

Conversation

@garlick
Copy link
Copy Markdown
Member

@garlick garlick commented Nov 8, 2023

Problem: the Rv1 attributes section is used by the early Fluxion queue implementation to store the assigned queue name in the system.scheduler key, but queues are now handled differently per RFC 33.

Drop the attributes section as discussed in #401

@grondo
Copy link
Copy Markdown
Contributor

grondo commented Nov 8, 2023

In case it wasn't clear in #401, this section is still required by Fluxion for multi-queue restart (on restart presumably Fluxion does not have access to jobspec to get the queue name, which for some reason it needs). I'll open an issue in flux-sched and refer to this PR.

@garlick
Copy link
Copy Markdown
Member Author

garlick commented Nov 8, 2023

Yes that is what I was thinking. Move RFCs forward, let code catch up. And it should have access to the jobspec...oh maybe you meant in the place where it's using the queue name.

@grondo
Copy link
Copy Markdown
Contributor

grondo commented Nov 8, 2023

FYI: flux-framework/flux-sched#1108

@grondo
Copy link
Copy Markdown
Contributor

grondo commented Nov 8, 2023

And it should have access to the jobspec...oh maybe you meant in the place where it's using the queue name.

Yeah, I'm guessing this is in the scheduler "hello" protocol. I think only R objects are returned by this protocol. Stashing the queue name in R may have been an optimization to avoid fetching the jobspec for every R? (I actually don't know, just guessing)

@garlick
Copy link
Copy Markdown
Member Author

garlick commented Sep 16, 2025

Since flux-framework/flux-sched#1108 was resolved, I think fluxion no longer requires the attributes section of Rv1. (As a test I installed the latest fluxion on my test system with queues enabled and verified that no attributes section appears in the R assigned to a test job). So if there was a concern about fluxion's design requiring that section, it appears to have been addressed :-)

Problem: the Rv1 attributes section is used by the early Fluxion
queue implementation to store the assigned queue name in the
system.scheduler key, but queues are now handled differently per
RFC 33.

Drop the attributes section.
@github-actions
Copy link
Copy Markdown

⚠️ linkcheck failed with status code 2

@garlick
Copy link
Copy Markdown
Member Author

garlick commented Mar 31, 2026

Rebased on current master and I think this has been ready to be considered for some time (somehow I forgot to get back to it!)

Copy link
Copy Markdown
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@garlick
Copy link
Copy Markdown
Member Author

garlick commented Mar 31, 2026

Thanks! Setting MWP.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 31, 2026

Merge Queue Status

  • Entered queue2026-03-31 14:39 UTC · Rule: default
  • Checks skipped · PR is already up-to-date
  • Merged2026-03-31 14:39 UTC · at e775b808eaa10ec12a5c6673bb9f1879e378b6ca

This pull request spent 13 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:flux-rfc
    • check-neutral = docs/readthedocs.org:flux-rfc
    • check-skipped = docs/readthedocs.org:flux-rfc
  • any of [🛡 GitHub branch protection]:
    • check-success = make check
    • check-neutral = make check
    • check-skipped = make check
  • any of [🛡 GitHub branch protection]:
    • check-success = validate commits
    • check-neutral = validate commits
    • check-skipped = validate commits

@mergify mergify Bot merged commit 8d32692 into flux-framework:master Mar 31, 2026
7 of 8 checks passed
@mergify mergify Bot removed the queued label Mar 31, 2026
@garlick garlick deleted the rfc20_attr branch March 31, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants