fix: inspect-graph type safety + npm audit CI job#14
Conversation
…raph
Debug tool used `as { label: string; nodeId: string }[]` instead of
the runtime type guard used by all other adapters.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request adds an npm audit job to the CI workflow, improves type safety in inspect-graph.ts by replacing unsafe type casting with a runtime guard, documents these changes in the CHANGELOG, and introduces an integration test for concurrent quest claims with last-writer-wins conflict resolution. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Two agents claim the same quest without seeing each other's patch. After materialization, both replicas converge on the same winner (lexicographically-greater writerId breaks the Lamport tie).
…r param (PR4 #13–#14) - Mark re-exported SecretAdapter type alias as @deprecated - Rename secretAdapter → secretPort in AnthropicLlmAdapter to match port naming
Fixes: - DepAnalysis: transitiveCount fallback `?? direct` → `?? 0` (#10) Wrong fallback inflated blocker scores for tasks with DONE dependents. - DashboardApp: drawer render guard `> 0` → `> 4` to prevent negative content widths during early animation frames (#4) - DashboardApp: add onComplete to drawer tween for exact snap (#7) - DashboardApp: remove dead `focus-panel` from ViewAction union (#5) - dashboard-view: campaign DAG falls back to declaration order when sortedCampaignIds is empty after filtering (#8) - my-stuff-drawer: guard pw < 10 returns empty string (#1) - my-stuff-drawer: use true pendingReview.length for label (#2) - check-graph-algorithms.sh: quote $SCAN_DIRS (#16) Tests: - Fix drawer test to assert on drawer-unique content (#13) - Add [ / ] view cycling tests with wraparound (#14) - Add 6 renderMyStuffDrawer unit tests (agent scope, empty width, submissions filtering, activity feed, pending count label) (#3) Total: 729 tests (up from 721)
Summary
as { label; nodeId }[]inline cast withtoNeighborEntries()runtime guard, matching all other adaptersauditjob runningnpm audit --omit=devto catch known vulnerabilities in production dependenciesTest plan
npm run buildpassesnpm run lintpassesnpm audit --omit=dev— 0 vulnerabilitiesSummary by CodeRabbit
Bug Fixes
Chores
Tests