Peeter/docstring clean new by ppiegaze · Pull Request #3225 · flyteorg/flytekit

ppiegaze · 2025-04-11T12:51:07Z

Tracking issue

NA

Why are the changes needed?

What changes were proposed in this pull request?

Update the docstring format

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This PR modernizes documentation across Flytekit modules by converting legacy reST formatting to markdown syntax, enhancing readability and standardizing code examples. It adds explicit type annotations and detailed parameter descriptions to docstrings, particularly in the webhook task module, while addressing bug fixes in critical code paths, especially in the entrypoint and Slurm connector modules to improve error handling and command execution reliability.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 5

flyte-bot · 2025-04-11T12:51:20Z

Code Review Agent Run #087561

Actionable Suggestions - 1

plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py - 1
- JSON parsing error after format change · Line 85-85

Review Details

Files reviewed - 70 · Commit Range: f79cd03..83bd484
- flytekit/__init__.py
- flytekit/bin/entrypoint.py
- flytekit/clients/auth_helper.py
- flytekit/clients/friendly.py
- flytekit/clients/raw.py
- flytekit/clis/sdk_in_container/serialize.py
- flytekit/configuration/__init__.py
- flytekit/configuration/file.py
- flytekit/core/annotation.py
- flytekit/core/array_node_map_task.py
- flytekit/core/base_sql_task.py
- flytekit/core/base_task.py
- flytekit/core/checkpointer.py
- flytekit/core/condition.py
- flytekit/core/context_manager.py
- flytekit/core/data_persistence.py
- flytekit/core/dynamic_workflow_task.py
- flytekit/core/launch_plan.py
- flytekit/core/legacy_map_task.py
- flytekit/core/local_fsspec.py
- flytekit/core/notification.py
- flytekit/core/promise.py
- flytekit/core/python_auto_container.py
- flytekit/core/python_customized_container_task.py
- flytekit/core/python_function_task.py
- flytekit/core/reference.py
- flytekit/core/resources.py
- flytekit/core/schedule.py
- flytekit/core/shim_task.py
- flytekit/core/task.py
- flytekit/core/testing.py
- flytekit/core/tracker.py
- flytekit/core/type_engine.py
- flytekit/core/workflow.py
- flytekit/deck/__init__.py
- flytekit/deck/deck.py
- flytekit/exceptions/eager.py
- flytekit/extend/__init__.py
- flytekit/extras/accelerators.py
- flytekit/extras/sqlite3/task.py
- flytekit/extras/tasks/shell.py
- flytekit/extras/webhook/task.py
- flytekit/lazy_import/lazy_module.py
- flytekit/models/core/execution.py
- flytekit/models/literals.py
- flytekit/models/security.py
- flytekit/remote/__init__.py
- flytekit/remote/backfill.py
- flytekit/remote/remote.py
- flytekit/tools/module_loader.py
- flytekit/tools/repo.py
- flytekit/types/directory/__init__.py
- flytekit/types/directory/types.py
- flytekit/types/error/__init__.py
- flytekit/types/file/__init__.py
- flytekit/types/file/file.py
- flytekit/types/iterator/__init__.py
- flytekit/types/pickle/__init__.py
- flytekit/types/structured/__init__.py
- plugins/flytekit-geopandas/flytekitplugins/geopandas/gdf_transformers.py
- plugins/flytekit-geopandas/tests/test_geopandas_plugin.py
- plugins/flytekit-hive/flytekitplugins/hive/task.py
- plugins/flytekit-kf-mpi/flytekitplugins/kfmpi/task.py
- plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py
- plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py
- plugins/flytekit-papermill/flytekitplugins/papermill/task.py
- plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py
- plugins/flytekit-slurm/flytekitplugins/slurm/script/connector.py
- tests/flytekit/integration/remote/workflows/basic/basic_workflow.py
- tests/flytekit/integration/remote/workflows/basic/hello_world.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

flyte-bot · 2025-04-11T13:59:53Z

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Documentation - Docstring and Documentation Modernization	- `__init__.py` - Modernized remote module docstrings and code examples to use markdown formatting, replacing obsolete reST sections with clear markdown syntax. - `backfill.py` - Updated backfill module documentation by converting code-block directives to markdown admonitions for notes and warnings. - `remote.py` - Replaced the reST note block with a markdown styled note, enhancing clarity in parameter descriptions. - `__init__.py` - Adjusted testing module docstrings to align with updated markdown formatting and improved module clarity. - `module_loader.py` - Refined TODO comment formatting by removing redundant comment symbols to clarify future enhancements. - `repo.py` - Converted reST references to markdown inline links in repository utilities, ensuring consistency in documentation. - `__init__.py` - Modernized directory type module documentation to markdown style with updated tables and section headers. - `types.py` - Replaced reST directives with markdown admonitions and warnings, clarifying usage and caveats in directory handling. - `__init__.py` - Cleaned up the error module by removing redundant documentation, resulting in a leaner docstring. - `__init__.py` - Updated file type documentation to reflect markdown styling improvements and a streamlined module overview. - `file.py` - Enhanced file handling function comments by replacing reST code-blocks with markdown formatting for better readability. - `__init__.py` - Performed minor adjustments on iterator module docstrings, shifting from reST to a minimalist markdown format. - `__init__.py` - Simplified pickle module docstring structures by adopting a concise markdown style. - `__init__.py` - Removed obsolete reST formatting in structured dataset documentation to provide a cleaner markdown presentation. - `__init__.py` - Updated in previous run – streamlined module-level documentation and modernized markdown formatting across client modules. - `pydoclint-errors-baseline.txt` - Updated baseline to remove obsolete docstring error codes in the core workflow module. - `basic_workflow.py` - Modernized inline documentation and converted reST links to markdown references in workflow comments. - `hello_world.py` - Replaced reST link syntax with markdown formatting in workflow documentation.

flyte-bot · 2025-04-11T13:59:55Z

        )
-        job_res = await conn.run(f"scontrol --json show job {resource_meta.job_id}", check=True)
-        job_info = json.loads(job_res.stdout)["jobs"][0]
+        job_res = await conn.run(f"scontrol show job {resource_meta.job_id}", check=True)


JSON parsing error after format change

The --json flag was removed from the scontrol show job command, but the code still tries to parse the output as JSON on line 88. This will cause a runtime error since the output format has changed.

Code suggestion

Check the AI-generated fix before applying

Suggested change

job_res = await conn.run(f"scontrol show job {resource_meta.job_id}", check=True)

job_res = await conn.run(f"scontrol --json show job {resource_meta.job_id}", check=True)

job_info = json.loads(job_res.stdout)["jobs"][0]

Code Review Run #087561

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

flyte-bot · 2025-04-16T14:32:18Z

Code Review Agent Run #c0739b

Actionable Suggestions - 2

plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py - 1
- Reference to undefined variable job_info · Line 88-88
plugins/flytekit-geopandas/flytekitplugins/geopandas/gdf_transformers.py - 1
- Incorrect directory creation logic for local paths · Line 46-47

Additional Suggestions - 10

flytekit/bin/entrypoint.py - 2
- Avoid f-string in exception message · Line 661-661
- Missing docstring and return type annotation · Line 698-701
flytekit/core/local_fsspec.py - 1
- Module docstring is empty · Line 1-1
flytekit/core/notification.py - 1
- Deprecated typing import needs updating · Line 11-11
flytekit/extras/tasks/shell.py - 1
- Exception with string literal in ValueError · Line 243-243
flytekit/lazy_import/lazy_module.py - 1
- Docstring formatting issues need correction · Line 31-31
flytekit/tools/module_loader.py - 1
- Replace Any with specific return type · Line 44-44
flytekit/tools/repo.py - 1
- Boolean positional argument in function definition · Line 55-55
flytekit/types/iterator/__init__.py - 1
- Empty module docstring needs content · Line 1-1
flytekit/types/pickle/__init__.py - 1
- Empty module docstring needs content · Line 1-1

Review Details

Files reviewed - 79 · Commit Range: cfdad78..0682305
- flytekit/__init__.py
- flytekit/bin/entrypoint.py
- flytekit/clients/auth_helper.py
- flytekit/clients/friendly.py
- flytekit/clients/raw.py
- flytekit/configuration/__init__.py
- flytekit/configuration/file.py
- flytekit/core/annotation.py
- flytekit/core/array_node_map_task.py
- flytekit/core/base_sql_task.py
- flytekit/core/base_task.py
- flytekit/core/checkpointer.py
- flytekit/core/condition.py
- flytekit/core/context_manager.py
- flytekit/core/dynamic_workflow_task.py
- flytekit/core/launch_plan.py
- flytekit/core/legacy_map_task.py
- flytekit/core/notification.py
- flytekit/core/python_function_task.py
- flytekit/core/resources.py
- flytekit/core/schedule.py
- flytekit/core/task.py
- flytekit/core/testing.py
- flytekit/tools/module_loader.py
- flytekit/core/shim_task.py
- flytekit/core/tracker.py
- flytekit/core/type_engine.py
- flytekit/deck/deck.py
- flytekit/exceptions/eager.py
- flytekit/extras/accelerators.py
- flytekit/extras/sqlite3/task.py
- flytekit/extras/tasks/shell.py
- flytekit/lazy_import/lazy_module.py
- flytekit/remote/__init__.py
- flytekit/remote/backfill.py
- flytekit/remote/remote.py
- flytekit/types/directory/types.py
- flytekit/types/file/file.py
- flytekit/core/data_persistence.py
- flytekit/core/local_fsspec.py
- flytekit/core/python_auto_container.py
- flytekit/core/python_customized_container_task.py
- flytekit/deck/__init__.py
- flytekit/extend/__init__.py
- flytekit/types/directory/__init__.py
- flytekit/types/error/__init__.py
- flytekit/types/iterator/__init__.py
- flytekit/types/pickle/__init__.py
- flytekit/types/structured/__init__.py
- plugins/flytekit-hive/flytekitplugins/hive/task.py
- plugins/flytekit-kf-mpi/flytekitplugins/kfmpi/task.py
- plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py
- plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py
- tests/flytekit/integration/remote/workflows/basic/basic_workflow.py
- plugins/flytekit-geopandas/flytekitplugins/geopandas/gdf_transformers.py
- plugins/flytekit-geopandas/tests/test_geopandas_plugin.py
- plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py
- plugins/flytekit-slurm/flytekitplugins/slurm/script/connector.py
- flytekit/extras/webhook/task.py
- flytekit/clis/sdk_in_container/serialize.py
- flytekit/core/reference.py
- flytekit/core/workflow.py
- flytekit/core/promise.py
- flytekit/models/core/execution.py
- flytekit/models/literals.py
- flytekit/models/security.py
- flytekit/tools/repo.py
- flytekit/types/file/__init__.py
- plugins/flytekit-papermill/flytekitplugins/papermill/task.py
- tests/flytekit/integration/remote/workflows/basic/hello_world.py
- flytekit/clients/__init__.py
- flytekit/extras/pytorch/__init__.py
- flytekit/extras/sklearn/__init__.py
- flytekit/extras/sqlite3/__init__.py
- flytekit/extras/tasks/__init__.py
- flytekit/extras/tensorflow/__init__.py
- flytekit/image_spec/__init__.py
- flytekit/interactive/__init__.py
- flytekit/testing/__init__.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

flyte-bot · 2025-04-16T15:29:58Z

+        job_res = await conn.run(f"scontrol show job {resource_meta.job_id}", check=True)

        # Determine the current flyte phase from Slurm job state
        job_state = job_info["job_state"][0].strip().lower()


Reference to undefined variable job_info

The variable job_info is used but not defined anywhere in the code. This will cause a runtime error. You need to define job_info before using it, likely by parsing the output from job_res.

Code suggestion

Check the AI-generated fix before applying

Suggested change

job_state = job_info["job_state"][0].strip().lower()

# Parse job information from job_res

job_info = parse_job_output(job_res.stdout)

job_state = job_info["job_state"][0].strip().lower()

Code Review Run #c0739b

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

flyte-bot · 2025-04-16T15:29:59Z

+            Path(uri).mkdir(parents=True, exist_ok=True)
+        uri = str(Path(uri) / "data.parquet")


Incorrect directory creation logic for local paths

The code creates a directory path but doesn't ensure the parent directory exists before creating the file. When uri is a remote path, Path(uri).mkdir() is called but only after checking if it's remote, which is incorrect.

Code suggestion

Check the AI-generated fix before applying

Suggested change

Path(uri).mkdir(parents=True, exist_ok=True)

uri = str(Path(uri) / "data.parquet")

parent_dir = Path(uri)

parent_dir.mkdir(parents=True, exist_ok=True)

uri = str(parent_dir / "data.parquet")

else:

uri = str(Path(uri) / "data.parquet")

Code Review Run #c0739b

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

wild-endeavor

make fmt not working, will take a look.

flyte-bot · 2025-04-17T17:32:17Z

Code Review Agent Run Status

Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
To trigger review, type /review in the comment and save.
You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

flyte-bot · 2025-04-18T13:52:15Z

Code Review Agent Run #439111

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 0682305..f4de3d7
- flytekit/extras/webhook/task.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

codecov · 2025-04-18T15:46:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (8abecfe) to head (c772027).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8abecfe) and HEAD (c772027). Click for more details.

HEAD has 17 uploads less than BASE

Flag BASE (8abecfe) HEAD (c772027)

28 11

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3225       +/-   ##
===========================================
- Coverage   89.81%   77.91%   -11.91%     
===========================================
  Files         136      237      +101     
  Lines        6599    23451    +16852     
  Branches        0     2927     +2927     
===========================================
+ Hits         5927    18271    +12344     
- Misses        672     4328     +3656     
- Partials        0      852      +852

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

flyte-bot · 2025-04-18T16:42:15Z

Code Review Agent Run #8ac766

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: f4de3d7..b9b844d
- flytekit/extras/webhook/task.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

ppiegaze · 2025-04-21T13:01:52Z

@wild-endeavor This still appears stuck. Any ideas?

flyte-bot · 2025-04-21T13:42:18Z

Code Review Agent Run #6053ce

Actionable Suggestions - 1

flytekit/core/legacy_map_task.py - 1
- Complex method with missing return type · Line 308-308

Additional Suggestions - 10

flytekit/bin/entrypoint.py - 3
- Avoid f-string in exception message · Line 661-661
- Missing return type and docstring · Line 698-701
- Redundant initialization of output_file_dict variable · Line 196-198
flytekit/core/local_fsspec.py - 1
- Module docstring is empty · Line 1-1
flytekit/core/notification.py - 1
- Deprecated typing.List import usage · Line 11-11
flytekit/exceptions/eager.py - 1
- Exception name missing Error suffix · Line 1-1
flytekit/extras/tasks/shell.py - 1
- Exception with string literal in ValueError · Line 243-243
flytekit/tools/repo.py - 1
- Boolean positional argument in function definition · Line 55-55
flytekit/types/iterator/__init__.py - 1
- Empty docstring in module init file · Line 1-1
flytekit/types/pickle/__init__.py - 1
- Empty docstring in module needs content · Line 1-1

Review Details

Files reviewed - 79 · Commit Range: b9b844d..be44c36
- flytekit/__init__.py
- flytekit/bin/entrypoint.py
- flytekit/clients/auth_helper.py
- flytekit/clients/friendly.py
- flytekit/clients/raw.py
- flytekit/configuration/__init__.py
- flytekit/configuration/file.py
- flytekit/core/annotation.py
- flytekit/core/array_node_map_task.py
- flytekit/core/base_sql_task.py
- flytekit/core/base_task.py
- flytekit/core/checkpointer.py
- flytekit/core/condition.py
- flytekit/core/context_manager.py
- flytekit/core/dynamic_workflow_task.py
- flytekit/core/launch_plan.py
- flytekit/core/legacy_map_task.py
- flytekit/core/notification.py
- flytekit/core/python_function_task.py
- flytekit/core/resources.py
- flytekit/core/schedule.py
- flytekit/core/task.py
- flytekit/core/testing.py
- flytekit/tools/module_loader.py
- flytekit/core/shim_task.py
- flytekit/core/tracker.py
- flytekit/core/type_engine.py
- flytekit/deck/deck.py
- flytekit/exceptions/eager.py
- flytekit/extras/accelerators.py
- flytekit/extras/sqlite3/task.py
- flytekit/extras/tasks/shell.py
- flytekit/lazy_import/lazy_module.py
- flytekit/remote/__init__.py
- flytekit/remote/backfill.py
- flytekit/remote/remote.py
- flytekit/types/directory/types.py
- flytekit/types/file/file.py
- flytekit/core/data_persistence.py
- flytekit/core/local_fsspec.py
- flytekit/core/python_auto_container.py
- flytekit/core/python_customized_container_task.py
- flytekit/deck/__init__.py
- flytekit/extend/__init__.py
- flytekit/types/directory/__init__.py
- flytekit/types/error/__init__.py
- flytekit/types/iterator/__init__.py
- flytekit/types/pickle/__init__.py
- flytekit/types/structured/__init__.py
- plugins/flytekit-hive/flytekitplugins/hive/task.py
- plugins/flytekit-kf-mpi/flytekitplugins/kfmpi/task.py
- plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py
- plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py
- tests/flytekit/integration/remote/workflows/basic/basic_workflow.py
- plugins/flytekit-geopandas/flytekitplugins/geopandas/gdf_transformers.py
- plugins/flytekit-geopandas/tests/test_geopandas_plugin.py
- plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py
- plugins/flytekit-slurm/flytekitplugins/slurm/script/connector.py
- flytekit/extras/webhook/task.py
- flytekit/clis/sdk_in_container/serialize.py
- flytekit/core/reference.py
- flytekit/core/workflow.py
- flytekit/core/promise.py
- flytekit/models/core/execution.py
- flytekit/models/literals.py
- flytekit/models/security.py
- flytekit/tools/repo.py
- flytekit/types/file/__init__.py
- plugins/flytekit-papermill/flytekitplugins/papermill/task.py
- tests/flytekit/integration/remote/workflows/basic/hello_world.py
- flytekit/clients/__init__.py
- flytekit/extras/pytorch/__init__.py
- flytekit/extras/sklearn/__init__.py
- flytekit/extras/sqlite3/__init__.py
- flytekit/extras/tasks/__init__.py
- flytekit/extras/tensorflow/__init__.py
- flytekit/image_spec/__init__.py
- flytekit/interactive/__init__.py
- flytekit/testing/__init__.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

Signed-off-by: Kevin Su <pingsutw@apache.org>

flyte-bot · 2025-04-22T11:02:26Z

Code Review Agent Run #bd05ad

Actionable Suggestions - 0

Additional Suggestions - 10

flytekit/bin/entrypoint.py - 6
- TODO comment missing author and link · Line 645-645
- Redundant initialization of output_file_dict variable · Line 190-190
- Use Path instead of os.path.splitext · Line 99-99
- Use Path with / operator · Line 178-178
- Use dict instead of Dict annotation · Line 193-193
- Missing trailing comma in tuple · Line 285-285
flytekit/core/local_fsspec.py - 1
- Empty module docstring needs content · Line 1-1
flytekit/types/directory/types.py - 1
- Missing return type annotation in method · Line 468-468
flytekit/types/iterator/__init__.py - 1
- Empty module docstring needs content · Line 1-1
flytekit/types/pickle/__init__.py - 1
- Empty docstring needs meaningful content · Line 1-1

Review Details

Files reviewed - 19 · Commit Range: be44c36..0620664
- flytekit/__init__.py
- flytekit/bin/entrypoint.py
- flytekit/clients/auth_helper.py
- flytekit/clients/friendly.py
- flytekit/core/context_manager.py
- flytekit/core/local_fsspec.py
- flytekit/core/schedule.py
- flytekit/core/type_engine.py
- flytekit/core/workflow.py
- flytekit/extras/pytorch/__init__.py
- flytekit/extras/webhook/task.py
- flytekit/types/directory/types.py
- flytekit/types/iterator/__init__.py
- flytekit/types/pickle/__init__.py
- flytekit/types/structured/__init__.py
- plugins/flytekit-slurm/flytekitplugins/slurm/function/connector.py
- pydoclint-errors-baseline.txt
- flytekit/configuration/__init__.py
- plugins/flytekit-geopandas/tests/test_geopandas_plugin.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by

Signed-off-by: Kevin Su <pingsutw@apache.org>

flyte-bot · 2025-04-22T14:42:29Z

Code Review Agent Run Status

Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
To trigger review, type /review in the comment and save.
You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

* chore: docstring cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: docstring cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: cleanup docstrings Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: fix merge conflicts Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: fix merge conflicts Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: fix merge conflicts Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: further cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: further cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: further docstring cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: further docstring cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * chore: further docstring cleanup Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * feat: replace sphinx directives with relevant shortcodes Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * Cleanup docstrings Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * fix missing code block delimiter Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * empty Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * Remove unneeded param in docstring Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * try fixing docstring again Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * disable monodoc Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: chmod77 <chmod777.ke@gmail.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>

ppiegaze requested review from Future-Outlier, cosmicBboy, davidmirror-ops, eapolinario, fg91, kumare3, pingsutw, samhita-alla, thomasjpfan and wild-endeavor as code owners April 11, 2025 12:51

flyte-bot reviewed Apr 11, 2025

View reviewed changes

ppiegaze force-pushed the peeter/docstring-clean-new branch from 9288172 to 72f239e Compare April 16, 2025 13:33

flyte-bot reviewed Apr 16, 2025

View reviewed changes

wild-endeavor reviewed Apr 17, 2025

View reviewed changes

chmod77 added 8 commits April 21, 2025 14:40

chore: docstring cleanup

fce72f2

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: docstring cleanup

55320f9

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: cleanup docstrings

85de871

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: fix merge conflicts

d9519ce

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: fix merge conflicts

f2723b3

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: fix merge conflicts

895ab05

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: further cleanup

bfad594

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: further cleanup

1f8ec31

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chmod77 and others added 9 commits April 21, 2025 14:40

chore: further docstring cleanup

7a2320c

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: further docstring cleanup

7bd911c

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

chore: further docstring cleanup

8f9450d

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

feat: replace sphinx directives with relevant shortcodes

5c458fd

Signed-off-by: chmod77 <chmod777.ke@gmail.com> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

Cleanup docstrings

ef44820

Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

fix missing code block delimiter

d182252

Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

empty

631c239

Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

Remove unneeded param in docstring

980eddc

Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

try fixing docstring again

be44c36

Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>

ppiegaze force-pushed the peeter/docstring-clean-new branch from b9b844d to be44c36 Compare April 21, 2025 12:40

flyte-bot reviewed Apr 21, 2025

View reviewed changes

Comment thread flytekit/core/legacy_map_task.py

pingsutw added 2 commits April 22, 2025 17:55

fix tests

c772027

Signed-off-by: Kevin Su <pingsutw@apache.org>

nit

0620664

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw previously approved these changes Apr 22, 2025

View reviewed changes

pingsutw closed this Apr 22, 2025

pingsutw reopened this Apr 22, 2025

disable monodoc

1f0b081

Signed-off-by: Kevin Su <pingsutw@apache.org>

pingsutw dismissed their stale review via 1f0b081 April 22, 2025 13:34

pingsutw approved these changes Apr 22, 2025

View reviewed changes

ppiegaze merged commit e72fbde into master Apr 22, 2025
115 checks passed

ppiegaze deleted the peeter/docstring-clean-new branch April 22, 2025 14:19

	job_res = await conn.run(f"scontrol show job {resource_meta.job_id}", check=True)
	job_res = await conn.run(f"scontrol --json show job {resource_meta.job_id}", check=True)
	job_info = json.loads(job_res.stdout)["jobs"][0]

		Path(uri).mkdir(parents=True, exist_ok=True)
		uri = str(Path(uri) / "data.parquet")

Conversation

ppiegaze commented Apr 11, 2025 • edited by pingsutw Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

Summary by Bito

Uh oh!

flyte-bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #087561

Uh oh!

flyte-bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist by Bito

Uh oh!

flyte-bot Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

flyte-bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c0739b

Uh oh!

flyte-bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

flyte-bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

wild-endeavor left a comment

Choose a reason for hiding this comment

Uh oh!

flyte-bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run Status

Uh oh!

flyte-bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #439111

Uh oh!

codecov Bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

flyte-bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #8ac766

Uh oh!

ppiegaze commented Apr 21, 2025

Uh oh!

flyte-bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #6053ce

Uh oh!

Uh oh!

flyte-bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #bd05ad

Uh oh!

Uh oh!

flyte-bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ppiegaze commented Apr 11, 2025 •

edited by pingsutw

Loading

flyte-bot commented Apr 11, 2025 •

edited

Loading

flyte-bot commented Apr 11, 2025 •

edited

Loading

flyte-bot commented Apr 16, 2025 •

edited

Loading

flyte-bot commented Apr 17, 2025 •

edited

Loading

flyte-bot commented Apr 18, 2025 •

edited

Loading

codecov Bot commented Apr 18, 2025 •

edited

Loading

flyte-bot commented Apr 18, 2025 •

edited

Loading

flyte-bot commented Apr 21, 2025 •

edited

Loading

flyte-bot commented Apr 22, 2025 •

edited

Loading

flyte-bot commented Apr 22, 2025 •

edited

Loading