fix(charts/linkwarden): adding existingSecret in auth.sso list does not prevent new secret from being created #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Currently in the Linkwarden chart, when setting
.Values.linkwarden.auth.sso[*].existingSecret, the chart still attempts to create the auth secret for that given provider. Beyond that there is an error whenclientIdandclientSecretare not set, leading to your values file requiring at least an empty value for both when using an existing secret.Special notes for your reviewer
We could probably bundle this in with #33 - I've left the Chart version untouched for that reason. If you'd rather this be a separate version bump I can add the change
Checklist
AUTHORSfilefix(charts/linkwarden): ...)