Skip to content

Conversation

@helionmusic
Copy link

What this PR does / why we need it

Currently in the Linkwarden chart, when setting .Values.linkwarden.auth.sso[*].existingSecret, the chart still attempts to create the auth secret for that given provider. Beyond that there is an error when clientId and clientSecret are not set, leading to your values file requiring at least an empty value for both when using an existing secret.

Special notes for your reviewer

We could probably bundle this in with #33 - I've left the Chart version untouched for that reason. If you'd rather this be a separate version bump I can add the change

Checklist

  • Chart Version bumped
  • User name added to AUTHORS file
  • Title of the PR starts with a valid commit scope as detailed in the CONTRIBUTING (e.g.
    fix(charts/linkwarden): ...)

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant