Skip to content

Conversation

@niko-exo
Copy link

@niko-exo niko-exo commented Jan 14, 2026

ref: https://app.clickup.com/t/86b855fdt

86b855fdt - fix: issues with unit tests

Changelog

  • Insert missing lodash reference.
  • Remove problematic yaml lodaer strings from imports.
  • Stub yaml files on jest unit tests.
  • Include .yml file on yaml webpack loader config.

Notes

  • Linter has performed some changes on the code.

Links

86b855fdt - Fix issues with unit tests on summit-admin repo

Summary by CodeRabbit

Release Notes

  • Refactor

    • Refactored internal code patterns and variable declarations to improve consistency and maintainability throughout the application
  • Chores

    • Updated build and test configuration to reliably handle YAML files across different file extensions
    • Streamlined project imports and dependencies for better code organization

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

The changes update YAML file handling across the project to support both .yml and .yaml extensions consistently, replace webpack loader-based YAML imports with direct ES6 imports, and modernize variable declarations from var to const in loop constructs.

Changes

Cohort / File(s) Summary
YAML Loader Configuration
package.json, webpack.common.js
Updated Jest and webpack configurations to recognize both .yml and .yaml file extensions. Jest transform pattern now includes yml alongside existing asset types. Webpack YAML loader test pattern changed from /\.yaml$/ to /\.ya?ml$/.
YAML Import Migration
src/app.js, src/models/member.js
Replaced webpack js-yaml-loader! prefixed imports with direct ES6 imports. exclusive-sections.yml in app.js and access-routes.yml in member.js now use standard import syntax instead of loader directives.
Code Modernization
src/models/member.js
Refactored all for-in loops iterating over this._member.groups to use const i instead of var i, tightening variable scoping across multiple methods.
New Dependency
src/actions/sponsorship-actions.js
Added import of lodash (import _ from "lodash"). No corresponding usage visible in the diff.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 YAML files now hop both ways,
.yml and .yaml brighten our days!
Loaders begone, imports so clean,
Const beats var—the best we've seen!
Hopping forward, scope so tight! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title includes a commit hash prefix (86b855fdt) which is non-descriptive noise, making it harder to understand the main change at a glance despite containing relevant context about fixing unit test issues. Remove the commit hash prefix and use a concise title like 'Fix unit test issues with YAML imports and lodash reference' to clearly communicate the primary change.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Niko <nicolas.olmos@exomindset.co>
Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit be1e1fd into master Jan 14, 2026
9 checks passed
@niko-exo
Copy link
Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants