MODEUR 178 include stats for titles with no yop#202
Merged
Conversation
- in cost per use
# Conflicts: # src/test/java/org/folio/eusage/reports/api/EusageReportsApiTest.java
adamdickmeiss
approved these changes
Mar 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a title has some usages entries with YoP and some without, those without would be ignored in reports split by YoP, like omitted from the usage-by-YoP lines and not included in the totals. (When a title that has only usage data without YoP, the figures will be included alright).
This commit assigns '0001' to usage lines with no YoP specified, to have the logic include the numbers.