perf: properly check for float mode in PutOut#825
Open
jodavies wants to merge 1 commit intoform-dev:masterfrom
Open
perf: properly check for float mode in PutOut#825jodavies wants to merge 1 commit intoform-dev:masterfrom
jodavies wants to merge 1 commit intoform-dev:masterfrom
Conversation
AC.DefaultPrecision is non-zero, even if we have not enabled floating point coefficients. Check for an allocated aux_ instead, to avoid searching terms for the floatstop unnecessarily.
|
coverage: 58.473% (-0.008%) from 58.481% — jodavies:perf-float-check into form-dev:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC.DefaultPrecision is non-zero, even if we have not enabled floating point coefficients. Check for an allocated aux_ instead, to avoid searching terms for the floatstop unnecessarily.
I don't measure any performance change due to this, but in principle the current behaviour is not correct.