Open
Conversation
…ge-and-stepstate-as-array-and-enum 36 implement simulation storage and stepstate as array and enum
Add double bicycle yaw rate model
goob10000
reviewed
Apr 14, 2026
|
|
||
| ### Cell layout and naming | ||
|
|
||
| - Cells are arranged in a **3 columns × 10 rows** grid inside the case (30 cells total). |
Member
There was a problem hiding this comment.
Despite being labeled cells, these aren't actually cells but packs of 20 cells. To be perfectly clear for fs-3, a cell is a single 18650 battery cell, a pack is 20 in parallel. The things labeled SEG4_CELL0 is the first cell in segment 5. (Also segments have been renamed to modules in fs-4 (comp change). Worth noting these bits and using correct terminology.
goob10000
reviewed
Apr 14, 2026
Member
There was a problem hiding this comment.
You're missing pack -> air (or what you have labeled as "cell" -> air)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added schematics markdown for batter thermal model for fs3