feat(core): model assembled property#23
Draft
paul-thebaud wants to merge 33 commits into
Draft
Conversation
Rework root types, all factories functions (dependencies, properties, etc.), drop extensions support and document API with appropriate experimental or internal tags. BREAKING CHANGE: Root dependencies types have been renamed (such as `Cache` or `RegistryI`). Builder pattern calls and extensions are removed, you must stop using them and change your depending types (`Action`, 'ContextEnhancer`, etc.) to remove extensions. Dependencies factories signature have been changed, you must use the new functions.
Add middlewares to action execution. BREAKING CHANGE: actions hooks now contains action instance instead of the context value.
Previously, instance state after a successful write action would be managed by both action's hooks and deserializer. With this fix, state will be synced by hooks only if not already done outside of the hooks (using snapshot comparison).
BREAKING CHANGE: `$model` property have been removed from snapshot, use `$instance.$model` instead.
BREAKING CHANGE: `requestTransformers`, `responseTransformers` and `errorTransformers` have been removed from HTTP adapter config and request config. You should now be using `middlewares`.
BREAKING CHANGE: custom transformer object must now use `makeCustomTransformer` instead of using an object implementing the `ObjectTransformer` type.
BREAKING CHANGE: `manager` option of `makeRefsCache` has been replaced by `makeRef`. `makeWeakRefManager` has been replaced by `makeWeakRefFactory`.
BREAKING CHANGE: signature of `Serializer` is fully changed to receive snapshots instead of instances.
BREAKING CHANGE: `config` chained modifier of relations factories is removed. You must use the new call signature to provide config objects.
paul-thebaud
added
type:feat
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 91.69% 91.80% +0.10%
==========================================
Files 218 231 +13
Lines 1578 1671 +93
Branches 444 516 +72
==========================================
+ Hits 1447 1534 +87
- Misses 117 121 +4
- Partials 14 16 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
assembledproperty which use the instance properties to create a new property.It works with a getter or a setter (or both), and can be memoized using a proxy.
It does not support strict typing for now.