Check dist.is_initialized before calling dist.get_rank()#194
Open
thanh-lam wants to merge 1 commit intofoundation-model-stack:mainfrom
Open
Check dist.is_initialized before calling dist.get_rank()#194thanh-lam wants to merge 1 commit intofoundation-model-stack:mainfrom
thanh-lam wants to merge 1 commit intofoundation-model-stack:mainfrom
Conversation
Signed-off-by: Thanh Lam <thanhlam@us.ibm.com>
thanh-lam
force-pushed
the
thanh-lam/save-val-1aiu
branch
from
57fd859 to
9d612ad
Compare
Author
|
Hi @gkumbhat - Thanks for helping create this PR! Did you or someone in your team review it? It's very simple change on one line and doesn't have any other dependencies. Let me know and I can invite others by comment. I don't have access to this repo to assign reviewers. |
|
@matthew-pisano This PR may help with getting DPP running on single AIU |
Author
|
@gkumbhat Thanks for approving! I see there're still "2 workflows awaiting approval". Who can we ask to help with reviewing? @Nhan-Hoang Can you help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the aiu-apps-sw-tracker issue #1688.
When
--save_validation_info_outputsis requested, in case of single aiu, callingdist.get_rank()will fail. Therefore, checkingdist.is_initialized()is required. Then, just simply set thebool=1.