build(deps): set transformers below 4.46, waiting on fixes#384
Merged
anhuong merged 1 commit intofoundation-model-stack:mainfrom Nov 1, 2024
Merged
build(deps): set transformers below 4.46, waiting on fixes#384anhuong merged 1 commit intofoundation-model-stack:mainfrom
anhuong merged 1 commit intofoundation-model-stack:mainfrom
Conversation
Signed-off-by: Anh Uong <anh.uong@ibm.com>
anhuong
requested review from
Ssukriti,
aluu317,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The triton fast_kernels are broken in transformers v4.46 due to the changes and the way the patching is done in fms-acceleration described here. In addition, the gradient_accumulation is deteriorated in v4.46 which is fixed in transformers PR which has been merged but not released yet.
In addition, upgrading transformers broke unit tests and is being resolved/discussion in #383.
Thus we will set transformers below v4.46 while we wait for these fixes to go in.
Related issue number
How to verify the PR
Was the PR tested