-
Notifications
You must be signed in to change notification settings - Fork 28
Introducing destroy_after config property and new model #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ron-shinall
wants to merge
14
commits into
fractaledmind:main
from
higher-pixels:destroy-after-new-model
Closed
Introducing destroy_after config property and new model #69
ron-shinall
wants to merge
14
commits into
fractaledmind:main
from
higher-pixels:destroy-after-new-model
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Just finishing up with RubyConf, will give this a review shortly |
Contributor
Author
|
I've been thinking about the scope for destroying records. It's currently scoped only to
config.solid_errors.destroy_after = { duration: 30.days, only: :resolved }
config.solid_errors.destroy_after = { duration: 30.days, only: :unresolved } # not sure why this would be used
config.solid_errors.destroy_after = { duration: 30.days } # all records older than duration |
Merged
Owner
|
Needed to make some tweaks, so opened #79, but this feature is live in v0.7.0 now. Thanks |
Contributor
Author
|
@fractaledmind thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
destroy_afterproperty, and also introduces theSolidErrors::Cleanermodel to handle the work.Motivation:
It would be nice if Solid Errors could be "self cleaning" by periodically destroying old resolved records.
@fractaledmind let me know your thoughts on this.
.delete_allto keep it fastSolidErrors::Maintainer,SolidErrors::Destroyer, etc.?6.1 Identified several improvements to the test configuration & test dummy app
6.2 Simplified the database structure in the test dummy app & removed the databases from the repo
6.3 Renamed the existing test to conform to common Rails conventions (
solid_errors_test.rbrather thantest_solid_errors.rb)