Merged
Conversation
frazane
reviewed
Jan 21, 2026
Owner
There was a problem hiding this comment.
Thanks @simon-hirsch! The reason for not decorating some functions with the lazy wrapper is that they are pre-compiled instead of being compiled the first time they are called. This is done for the most popular metrics, and it was a tradeoff for speeding up import times. Could you revert that specific change?
Also side note: doing this
@lazy_gufunc_wrapper_mv
@guvectorize(
[
"void(float32[:], float32[:,:], float32[:])",
"void(float64[:], float64[:,:], float64[:])",
],
"(d),(m,d)->()",
cache=True,
)
is redundant because if the types are specified in guvectorize the additional decorator is not necessary.
This reverts commit 89ff80a.
Contributor
Author
|
Done :) |
frazane
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small MR for aligning return types, see #107