Skip to content

Rdoc scraper fixes#2664

Merged
simon04 merged 3 commits intofreeCodeCamp:mainfrom
thedanbob:fix-rdoc
Mar 18, 2026
Merged

Rdoc scraper fixes#2664
simon04 merged 3 commits intofreeCodeCamp:mainfrom
thedanbob:fix-rdoc

Conversation

@thedanbob
Copy link
Contributor

@thedanbob thedanbob commented Mar 18, 2026

This fixes the following issues with rdoc docs:

  • "Show source" button being shown when no source is available
  • Source block being placed above the method header for newer rdoc (e.g. ruby 4.0)

Tested working on ruby 3.4, ruby 4.0, and rails 8.1.

@thedanbob thedanbob requested a review from a team as a code owner March 18, 2026 15:10
Copy link
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simon04 simon04 merged commit a8420b4 into freeCodeCamp:main Mar 18, 2026
2 checks passed
@thedanbob thedanbob deleted the fix-rdoc branch March 18, 2026 17:36
@thedanbob
Copy link
Contributor Author

FYI Rails 8.1.2 needs some additional changes to the scraper to render correctly, which are included in my other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants