Skip to content

fix #33 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freelw merged 3 commits into from
Jun 16, 2025
Merged

fix #33 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
082ea68
opt makefile
Jun 16, 2025
7039c94
update
Jun 16, 2025
3ac86a0
fix buffer overflow
Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dataloaders/language_model/lm_dataloader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void LMDataLoader::get_token_ids(
int token_ids_size = std::min((int)token_ids.size(), max_token_ids_size);
std::cout << "token_ids_size : " << token_ids_size << std::endl;

for (size_t i = 0; i < token_ids_size; ++i) {
for (size_t i = 0; i < token_ids_size && i + num_steps < token_ids_size; ++i) {
std::vector<uint> src_step_tokens;
std::vector<uint> tgt_step_tokens;
for (size_t j = 0; j < num_steps && (i + j) < token_ids_size - 1; ++j) {
Expand Down
14 changes: 9 additions & 5 deletions lm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ std::vector<uint> trim_or_padding(const std::vector<uint>& src, uint max_len, ui
std::vector<uint> res = src;
if (src.size() > max_len) {
res.resize(max_len);
} else {
}
else {
res.resize(max_len, pad_id);
}
return res;
Expand Down Expand Up @@ -98,7 +99,7 @@ int main(int argc, char* argv[]) {

int opt;
int epochs = 10;
int batch_size = 16;
int batch_size = 4;
int gpu = 1;
int max_words_cnt = 256;
float lr = 0.001f;
Expand Down Expand Up @@ -246,7 +247,8 @@ int main(int argc, char* argv[]) {
auto origin_size = src_token_ids.size();
if (src_token_ids.size() < num_steps) {
src_token_ids.resize(num_steps, loader.get_pad_id());
} else if (src_token_ids.size() > num_steps) {
}
else if (src_token_ids.size() > num_steps) {
src_token_ids.erase(src_token_ids.begin(), src_token_ids.end() - num_steps);
}
auto cur_step = origin_size - 1;
Expand Down Expand Up @@ -284,15 +286,17 @@ int main(int argc, char* argv[]) {
if (cur_step >= num_steps - 1) {
src_token_ids.push_back(max_index);
src_token_ids.erase(src_token_ids.begin(), src_token_ids.end() - num_steps);
} else {
}
else {
src_token_ids[++cur_step] = max_index;
}
}
std::cout << std::endl;
std::cout << "-----------------" << std::endl;
::free(res_buffer);
}
} else {
}
else {
init_dec_valid_lens_for_training(dec_valid_lens);
signal(SIGINT, signal_callback_handler);
int epoch = 0;
Expand Down
2 changes: 2 additions & 0 deletions makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ endif
ifeq ($(RELEASE),1)
NVCC_CFLAGS += -DNDEBUG
NVCC_CFLAGS := $(filter-out -G,$(NVCC_CFLAGS))
else
NVCC_CFLAGS := $(filter-out -O3,$(NVCC_CFLAGS))
endif

ifeq ($(MACOS), 1)
Expand Down