feat: remove legacy secret message types#51
Merged
iduartgomez merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
Commit 891415c2 introduced synchronous host functions (DelegateCtx::get_secret(), set_secret(), etc.) that replace the old async message round-trip pattern (GetSecretRequest -> GetSecretResponse). This removes all legacy types: - GetSecretRequest, GetSecretResponse, SetSecretRequest structs - Their variants from InboundDelegateMsg and OutboundDelegateMsg enums - DelegateRequest::GetSecretRequest variant - FlatBuffers schema entries and generated code - All associated serialization/deserialization code SecretsId is kept as it's used by the new host functions. Bumps version to 0.1.34. Closes #1500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1500:
GetSecretRequestappeared inInboundDelegateMsgdespite delegates only sending requests, not receiving them. The old async message round-trip pattern (GetSecretRequest->GetSecretResponse) was architecturally wrong and has been fully superseded by synchronous host functions (DelegateCtx::get_secret(),set_secret(), etc.) introduced in commit 891415c2.Solution
Remove all legacy secret message types:
GetSecretRequest,GetSecretResponse,SetSecretRequestInboundDelegateMsg,OutboundDelegateMsg, andDelegateRequestcommon.fbs,client_request.fbs,host_response.fbsSecretsIdis kept — it's used by the new host functions innative_api.rsandsecrets_store.rs.Version bumped to 0.1.34.
Testing
cargo fmt && cargo clippy --all-targets --all-features— cleancargo test— 6 passed, 0 failedFixes
Closes #1500