fix: set realistic connection limits for six-peer regression test#102
Merged
fix: set realistic connection limits for six-peer regression test#102
Conversation
The test creates a 7-node network (6 peers + 1 gateway) but peers default to min_connections=25, which is unachievable. This causes perpetual topology churn as peers endlessly try to reach the minimum, destabilizing existing connections and breaking UPDATE propagation. Setting min=4, max=5 gives peers achievable targets, eliminating the connection churn that was causing flaky test failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sanity
added a commit
to freenet/freenet-core
that referenced
this pull request
Feb 16, 2026
River PR freenet/river#102 merged, setting min_connections=4 and max_connections=5 for the six-peer test to match the 7-node network size. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sanity
added a commit
to freenet/freenet-core
that referenced
this pull request
Feb 16, 2026
River PR freenet/river#102 merged, setting min_connections=4 and max_connections=5 for the six-peer test to match the 7-node network size. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The six-peer-regression CI test in freenet-core has been consistently failing since Feb 15 06:02 UTC. The root cause: peers default to
min_connections=25but only 7 nodes exist (6 peers + 1 gateway). Peers can never reach the minimum, causing perpetual topology management churn that destabilizes existing connections and breaks UPDATE propagation paths.Solution
Set
min_connections(4)andmax_connections(5)on theTestNetwork::builder()— realistic targets for a 7-node network. This eliminates the connection churn while still exercising topology management.Testing
This fix addresses the consistent six-peer-regression failures across all branches in freenet-core CI (topology-sim, fix/2888-improve-reservation-cleanup, claude/test-anomaly-detection).
[AI-assisted - Claude]