Fix scheduler bugs on v1.x.x#248
Merged
Marenz merged 4 commits intofrequenz-floss:v1.x.xfrom Mar 12, 2026
Merged
Conversation
github-actions
bot
added
part:docs
list.pop(idx) removes an arbitrary element from the heap without restoring the heap property. Add heapify() after the removal to fix the invariant. Change the return type from bool to QueueItem | None so callers can inspect the removed item (needed for the follow-up fix). Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
When a dispatch update arrives at exactly the stop boundary, _remove_scheduled consumes the pending stop event from the queue. _update_changed_running_state does not fire because old_dispatch.started and dispatch.started are both False at this point. The actor would then remain running indefinitely. Fix: if _remove_scheduled returned a stop event (priority == 1) and the dispatch is no longer started, send the running-state change explicitly. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
requested review from
llucax and
stefan-brus-frequenz
and removed request for
a team
Contributor
Author
|
This is essentially the same as the already approved PR, just on the correct branch. Merging.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased follow-up of #246 for
v1.x.x.time-machine3 API used onv1.x.x