Add warning about requests dependencies to golden tests#526
Closed
llucax wants to merge 1 commit intofrequenz-floss:v0.x.xfrom
Closed
Add warning about requests dependencies to golden tests#526llucax wants to merge 1 commit intofrequenz-floss:v0.x.xfrom
llucax wants to merge 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
We are currently having CI failures because there are some issues with transitive dependencies. It is already [fixed upstream](psf/requests#7220) but not release yet. For now we just adjust golden tests to expect these warnings. We will have to roll this back when upstream is fixed. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
florian-wagner-frequenz
and removed request for
a team
github-actions
bot
added
the
part:tests
llucax
added
the
type:tech-debt
Contributor
Author
|
Force-merging this as it is making all PRs fail. |
Contributor
Author
|
Oh, damn. The error include the full path, so test will always fail unless they are always run from the same absolute path 😒 |
Contributor
Author
|
Will try a different approach. |
Contributor
Author
|
Alternative: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently having CI failures because there are some issues with transitive dependencies. It is already fixed upstream but not release yet. For now we just adjust golden tests to expect these warnings.
We will have to roll this back when upstream is fixed.
Workaround for #527.